++ review comments: last ones

Signed-off-by: Ivan Mikheykin <[email protected]>

Author: diafour

images/virtualization-artifact/pkg/controller/dvcr-maintenance/condition/deployment.go

@@ -45,34 +45,27 @@ func NewMaintenanceCondition(reason dvcrdeploymentcondition.MaintenanceReason, m
 }
 
 // UpdateMaintenanceCondition replaces or removes Maintenance condition from deployment status.
-// Return true if status was changed.
 func UpdateMaintenanceCondition(deploy *appsv1.Deployment, reason dvcrdeploymentcondition.MaintenanceReason, msgf string, args ...any) {
 	if deploy == nil {
 		return
 	}
 
 	condition := NewMaintenanceCondition(reason, msgf, args...)
 
-	// Deploy has no conditions, create new slice.
-	if len(deploy.Status.Conditions) == 0 {
-		deploy.Status.Conditions = []appsv1.DeploymentCondition{condition}
-	}
-
 	// Add or update existing condition.
-	filteredConditions := make([]appsv1.DeploymentCondition, 0)
-	existed := false
+	filteredConditions := make([]appsv1.DeploymentCondition, 0, len(deploy.Status.Conditions))
+	existing := false
 	for _, cond := range deploy.Status.Conditions {
 		if cond.Type == dvcrdeploymentcondition.MaintenanceType {
 			if cond.Reason != condition.Reason || cond.Message != condition.Message {
 				condition.LastTransitionTime = metav1.Now()
 			}
 			cond = condition
-			existed = true
+			existing = true
 		}
-		// Copy non-maintenance conditions.
 		filteredConditions = append(filteredConditions, cond)
 	}
-	if !existed {
+	if !existing {
 		filteredConditions = append(filteredConditions, condition)
 	}
 	deploy.Status.Conditions = filteredConditions

images/virtualization-artifact/pkg/controller/dvcr-maintenance/internal/life_cycle.go

@@ -45,6 +45,10 @@ func NewLifeCycleHandler(client client.Client, dvcrService dvcrtypes.DVCRService
 }
 
 func (h LifeCycleHandler) Handle(ctx context.Context, req reconcile.Request, deploy *appsv1.Deployment) (reconcile.Result, error) {
+	if deploy == nil || deploy.GetDeletionTimestamp() != nil {
+		return reconcile.Result{}, nil
+	}
+
 	if req.Namespace == dvcrtypes.CronSourceNamespace && req.Name == dvcrtypes.CronSourceRunGC {
 		dvcrcondition.UpdateMaintenanceCondition(deploy,
 			dvcr_deployment_condition.InProgress,