Skip to content

Conversation

loktev-d
Copy link
Contributor

@loktev-d loktev-d commented Sep 1, 2025

Description

Fix the VirtualDisk controller to respect user-specified storageClassName when creating disks from VirtualDiskSnapshot. Previously, the controller was always using the storage class from the original disk (stored in VolumeSnapshot annotations), completely ignoring the user-specified value in spec.persistentVolumeClaim.storageClassName. Also add error message when user tries to perform cross-provider restore.

Why do we need it, and what problem does it solve?

When users tried to restore a VirtualDisk from a snapshot with a different storage class, the parameter spec.persistentVolumeClaim.storageClassName was silently ignored. The restored disk would always use the same storage class as the original disk.

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vd
type: fix
summary: respect user-specified storage class when restoring from snapshot

Signed-off-by: Daniil Loktev <[email protected]>
@loktev-d loktev-d marked this pull request as draft September 1, 2025 12:22
@loktev-d loktev-d added this to the v0.26.0 milestone Sep 1, 2025
@loktev-d loktev-d added the e2e/run Run e2e test on cluster of PR author label Sep 1, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Sep 1, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Sep 1, 2025
@loktev-d loktev-d added the e2e/run Run e2e test on cluster of PR author label Sep 1, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Sep 1, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Sep 1, 2025
@loktev-d loktev-d added the e2e/run Run e2e test on cluster of PR author label Sep 1, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Sep 1, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: success.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Sep 1, 2025
@loktev-d loktev-d marked this pull request as ready for review September 2, 2025 05:50
@nevermarine nevermarine modified the milestones: v1.0.0, v1.1.0 Sep 11, 2025
@loktev-d loktev-d marked this pull request as draft September 17, 2025 07:16
Signed-off-by: Daniil Loktev <[email protected]>
@loktev-d loktev-d added the e2e/run Run e2e test on cluster of PR author label Sep 17, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Sep 17, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Sep 17, 2025
@loktev-d loktev-d added the e2e/run Run e2e test on cluster of PR author label Sep 18, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Sep 18, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Sep 18, 2025
@loktev-d loktev-d added the e2e/run Run e2e test on cluster of PR author label Sep 18, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Sep 18, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: success.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Sep 18, 2025
@loktev-d loktev-d marked this pull request as ready for review September 19, 2025 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants