Skip to content

Conversation

LopatinDmitr
Copy link
Contributor

@LopatinDmitr LopatinDmitr commented Sep 19, 2025

Description

Fix creating snapshot from vm with awaiting restart changes

Why do we need it, and what problem does it solve?

When creating a snapshot from a VM with changes requiring a restart, the snapshot remained in Pending status.

What is the expected result?

The snapshot is now always created based on the configuration defined in the .spec at the moment the snapshot is taken.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vm
type: fix
summary: fix creating snapshot from vm with awaiting restart changes

@LopatinDmitr LopatinDmitr changed the title fix(vmsnapshot): snapshot when vm has changes fix(vmsnapshot): fix snapshot when vm has changes Sep 19, 2025
@LopatinDmitr LopatinDmitr added the e2e/run Run e2e test on cluster of PR author label Sep 19, 2025
@LopatinDmitr LopatinDmitr added this to the v1.1.0 milestone Sep 19, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Sep 19, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Sep 19, 2025
@LopatinDmitr LopatinDmitr added the e2e/run Run e2e test on cluster of PR author label Sep 20, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Sep 20, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Sep 20, 2025
@LopatinDmitr LopatinDmitr force-pushed the fix/vmsnapshot/fix-snapshot-when-vm-has-changes branch from d177e83 to c0cce2d Compare September 21, 2025 07:18
@LopatinDmitr LopatinDmitr added the e2e/run Run e2e test on cluster of PR author label Sep 21, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Sep 21, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Sep 21, 2025
@LopatinDmitr LopatinDmitr changed the title fix(vmsnapshot): fix snapshot when vm has changes fix(vmsnapshot): fix creating snapshot from vm with awaiting restart changes Sep 21, 2025
@LopatinDmitr LopatinDmitr marked this pull request as ready for review September 21, 2025 13:02
@Isteb4k Isteb4k self-requested a review September 22, 2025 09:25
Signed-off-by: Dmitry Lopatin <[email protected]>
@LopatinDmitr LopatinDmitr force-pushed the fix/vmsnapshot/fix-snapshot-when-vm-has-changes branch from c0cce2d to 2a68598 Compare September 22, 2025 11:34
@LopatinDmitr LopatinDmitr merged commit 8cc5a1d into main Sep 23, 2025
25 of 27 checks passed
@LopatinDmitr LopatinDmitr deleted the fix/vmsnapshot/fix-snapshot-when-vm-has-changes branch September 23, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants