Build script improvements

Author: decoyjoe

.github/workflows/build.yml

@@ -12,6 +12,8 @@ jobs:
         run: ./init.sh
       - name: Build sanoid-portable binary
         run: |
+          # Build on Ubuntu
+
           # Add a new binfmt entry that matches APE's (Actually Portable Executable)'s
           # magic number to avoid execution by Ubuntu's built-in "MZ" binfmt
           # interpreter which "helpfully" tries to run the binary with WINE.

.gitignore

@@ -1 +1 @@
-/build/
+/output/

README.md

@@ -67,7 +67,7 @@ Build the executable:
 
 This script will download and configure APPerl, download necessary Perl modules, and build the portable Sanoid binary.
 
-The executable gets built to `build/sanoid-portable`.
+The executable gets built to `output/sanoid-portable`.
 
 ## License
 

build.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -euo pipefail
 
@@ -12,13 +12,13 @@ echo "Building sanoid-portable version ${SANOID_PORTABLE_VERSION}, based on Sano
 repo_root="$(realpath "$(dirname "$0")")"
 
 # Cleanup previous artifacts if they exist
-if [ -d build ]; then
-  echo 'Cleaning up previous build...'
-  rm -rf build
+if [ -d output ]; then
+  echo 'Cleaning up previous build output...'
+  rm -rf output
 fi
 
-mkdir build
-pushd build > /dev/null
+mkdir output
+pushd output > /dev/null
 
 echo 'Downloading necessary modules...'
 

init.sh

@@ -1,13 +1,14 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -euo pipefail
 
 # Identify the operating system from /etc/os-release
-OS=$(grep ^ID= /etc/os-release | cut -d '=' -f 2 | tr -d '"')
+source /etc/os-release
+OS=$ID
 
-# Check if the OS is Debian or a Debian derivative (like Ubuntu)
+# The only build OS's we've tested.
 if [[ "$OS" != 'debian' && "$OS" != 'ubuntu' ]]; then
-  echo 'Error: This script is intended only for Debian-based systems.'
+  echo "Error: Unsupported operating system. This script only supports Debian and Ubuntu."
   exit 1
 fi