Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dcr: Make tip an atomic. #3087

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

dcr: Make tip an atomic. #3087

wants to merge 1 commit into from

Conversation

JoeGruffins
Copy link
Member

@JoeGruffins JoeGruffins commented Nov 19, 2024 •
edited
Loading

closes #3086

*NativeWallet.mixFunds() is called in *ExchangeWallet.handleTipChange as dcr.cycleMixer where dcr.tipMtx is held. This is similar to the deadlock in #3066 .

martonp
martonp reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@martonp martonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about if the tip becomes an atomic.Value, and we just have the tipMtx in handleTipChange to avoid concurrent execution. Still agree that syncTxHistory can be run as a goroutine.

@JoeGruffins
Copy link
Member Author

Yeah That works. More changes but maybe worth it if theres more bugs lurking around.

@JoeGruffins JoeGruffins force-pushed the fixmixerdeadlock branch 2 times, most recently from c4f3bfd to cbeaa2f Compare November 20, 2024 08:55
@JoeGruffins JoeGruffins changed the title dcr: Lock tip mtx in goroutine. dcr: Make tip an atomic. Nov 20, 2024
@JoeGruffins
Copy link
Member Author

Now tip is an atomic.Value

@dev-warrior777
Copy link
Contributor

How about if the tip becomes an atomic.Value, and we just have the tipMtx in handleTipChange to avoid concurrent execution. Still agree that syncTxHistory can be run as a goroutine.

I did that with goele now tested 30..40 hours .. definitely improvement

@buck54321 buck54321 requested a review from martonp December 2, 2024 19:22
@JoeGruffins
Copy link
Member Author

Just rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dev-warrior777 dev-warrior777 dev-warrior777 approved these changes

@martonp martonp martonp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

client: Hang on shutdown on simnet.
3 participants
@JoeGruffins @dev-warrior777 @martonp