Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhelpful incomplete UI cancel dialog. #3111

Open
dev-warrior777 opened this issue Dec 6, 2024 · 6 comments
Open

Unhelpful incomplete UI cancel dialog. #3111

dev-warrior777 opened this issue Dec 6, 2024 · 6 comments

Comments

@dev-warrior777
Copy link
Contributor

dev-warrior777 commented Dec 6, 2024

  1. Trying to cancel shows incomplete dialog

image

The remaining "what"?

  1. When Submit is clicked there is an indication that the button was clicked - a short color change
    on the Submit button but the dialog does not go away but a log line is emitted.
@dev-warrior777
Copy link
Contributor Author

The above is from the MM main page .. Markets page to be investigated ..

@davecgh
Copy link
Member

davecgh commented Dec 6, 2024

It happens from toaster menu -> Order history (aka the /orders route) -> order detail link (aka the `/order/ route) -> Cancel order button in the status section too.

Also, here i the animated gif showing the click. The one in the issue description seems to just be a static pic.

dex_cancel_fail

@davecgh
Copy link
Member

davecgh commented Dec 6, 2024

Also, from the dev channel where I was discussing this, the backend bison wallet log (dexc.log) shows:

... [ERR] WEB: error cancelling order [abc]: Cancel: failed to find order [abc]

However, that error is not propagated back to the UI and the dialog just does nothing per the attached animated gif.

Note that there are no JS console errors either. The error is complete invisible to the UI aside from the dialog just not doing anything or dismissing after hitting Submit.

@dev-warrior777
Copy link
Contributor Author

dev-warrior777 commented Dec 6, 2024

The one in the issue description seems to just be a static pic.

My bad I tried to just copy the image here .. so deleted that one with an edit after posting. Thanks

@dev-warrior777
Copy link
Contributor Author

dev-warrior777 commented Dec 6, 2024

This from master

image

Got here by clicking the X - from markets page - to cancel One of the 2 x 1.0$ mm orders running. So either fixed or Polygon UI asset updates this correctly

At least we know what the missing context is now

[Submit] button works and order is "cancelled" .. then the dialog disappears and we are back on the Markets page.

2024-12-06 14:27:54.579 [INF] CORE: Cancel order 29d6477c0ace306f972c09cc0bf3956ed9d78f9102640970d9dc7e42c42ef912 targeting order 45350a69ca9a58072c8f2ab7a9b4e811cd1431ec012012df0e05c6c3ff79

No restarts yet.

@dev-warrior777
Copy link
Contributor Author

dev-warrior777 commented Dec 6, 2024

Even after restart - ^C + y - restart the 2 mm orders show on the market still even though I canceled just one and that may be correct behavior.

Anyway now I tried cancel both sides (I originally had a bot with 1 order on each side)

  • Sell side just sent the message .. no error.
  • Buy side:
    image

So at least we know that there is the potential for this dialog to show feedback on submit.

Switch to MM page and see this
image

Switch back to market page my 2 x 1.0$ orders are not shown
image

Switch back to MM page and hit [Delete Bot] and this is the only thing I see in the logs - which looks right

2024-12-06 15:24:40.496 [TRC] WEB[WS]: message of type 1 received for route unmarket

Lastly shutdown bisonw with only ^C as no outstanding orders.

  • Just functional testing - no attempt to follow the code yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants