Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: wallet lock/unlock feature is no longer relevant #3112

Open
norwnd opened this issue Dec 6, 2024 · 0 comments
Open

ui: wallet lock/unlock feature is no longer relevant #3112

norwnd opened this issue Dec 6, 2024 · 0 comments

Comments

@norwnd
Copy link
Contributor

norwnd commented Dec 6, 2024

I've noticed I never once used (or even payed attention to) lock/unlock wallet feature in UI, it just seems to unlock automatically whenever it needs to (as it should 👍 ),

not sure why this was a feature to begin with, but if there is no strong reason to have it - I'd suggest to remove it (to keep UI as simple & clean as possible),

besides, it doesn't seem to work 100% correctly in every place, for example:

  • when I login and navigate to /wallets page - Polygon-related wallets show as if they are "locked", but I still can send transactions and trade on wallet-affiliated markets (and when I do, eventually wallet automatically flips to "unlocked")
  • I can "lock" my BTC wallet and place a trade while it's being locked, which doesn't make sense
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant