Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create interface with tests #17

Open
kkweon opened this issue Jul 16, 2020 · 3 comments
Open

Create interface with tests #17

kkweon opened this issue Jul 16, 2020 · 3 comments

Comments

@kkweon
Copy link
Member

kkweon commented Jul 16, 2020

일단 시작하기 위해서 테스트코드와 인터페이스를 작성해놓으면 좋을 것 같습니다.

네이밍과 파일은 말되기만 하면 ok

export function generateProtoDefinition(ProtoMessage message): string {
  return ""
}

test

it.skip("should generate a simple proto message", () => {
  const input = `{ "name": "Mark" }`
  const protoMessage = parseJSONToProtoMessage(input)

  expect(generateProtoDefinition(protoMessage)).toStrictEqual(`message Root {
  string name = 1;
}`)

}) // it.skip
@TangoEnSkai
Copy link
Collaborator

의견 감사합니다. 저도 동의합니다. 전체적인 테스트코드와 인터페이스를 작성해 보도록 하겠습니다.
요즘 많은 일들이 있어서 손을 전혀 못대고 있었네요. 곧 PR로 돌아오겠습니다!

@kkweon
Copy link
Member Author

kkweon commented Aug 27, 2020

제가 그냥 작업해도 될까요?

@TangoEnSkai
Copy link
Collaborator

댓글 지금 확인했네요.. 네, 아무래도 그게 더 좋을 것 같습니다. 늦게 답변드려 죄송합니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants