module_json: give AbacusJson a read-only document view and pass general_info its inputs, removing the last access hack in the module

para_json_test.cpp needed `#define private public` for two independent reasons.
Both are now addressed by real interfaces rather than by a friend declaration.

1) It read the private static `AbacusJson::doc` in 84 places to inspect what
   add_json() had produced, and reset it in 5 more. AbacusJson gains two public
   members next to the existing allocator():

     static const rapidjson::Document& document();  // read-only view
     static void reset();                           // start a fresh empty object

   All 84 reads are const (HasMember, operator[], Get*/Is*), so the const view is
   sufficient and the document cannot be mutated through it. The 5 resets were
   `doc.SetObject()` twice and `doc.Parse("{}")` three times; both leave an empty
   object, and add_json() itself already calls SetObject() when the document is
   not an object, so reset() covers both.

2) It populated a local `Parameter` -- whose `input` and `sys` members are
   private -- only to hand it to gen_general_info(). That function read six
   values from it, so it now takes them directly:

     void gen_general_info(const Input_para& inp,
                           const std::time_t start_time,
                           const std::string& stru_file);

   This follows the precedent set by gen_init(ucell, param.inp) in the same
   module. Its one caller, create_Json() in para_json.cpp, already receives
   `Parameter&` as an argument, so the call site reads no global state; the test
   now builds a plain `Input_para` (a struct with public members) and passes the
   time and structure path as values.

   general_info.h consequently drops its `parameter.h` include in favour of a
   forward declaration of Input_para, again matching init_info.h.

Also deletes a commented-out duplicate of the add_json block in
general_info.cpp that still referred to the removed `param`.

No assertion or expected value changed. This target only builds under
ENABLE_RAPIDJSON, which the local build box cannot provide (rapidjson is not
installed and cannot be fetched), so it is verified by CI.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: Critsium-xy

source/source_io/module_json/abacusjson.h

@@ -66,6 +66,21 @@ class AbacusJson
       return doc.GetAllocator();
     }
 
+    /// @brief Read-only view of the json tree accumulated so far, for inspecting
+    ///        what add_json() produced.
+    static const rapidjson::Document& document()
+    {
+        return doc;
+    }
+
+    /// @brief Discard everything accumulated so far, leaving an empty json object.
+    ///        The document is static, so a caller that starts a fresh tree must say
+    ///        so explicitly rather than inherit the previous one.
+    static void reset()
+    {
+        doc.SetObject();
+    }
+
     /**
      *  @brief: The template specialization method adds value to the doc tree
      *

source/source_io/module_json/general_info.cpp

@@ -3,14 +3,15 @@
 #include "para_json.h"
 #include "abacusjson.h"
 #include "source_base/parallel_global.h"
+#include "source_io/module_parameter/input_parameter.h"
 #include "source_main/version.h"
 
 // Add json objects to gener_info
 namespace Json
 {
 
 #ifdef __RAPIDJSON
-void gen_general_info(const Parameter& param)
+void gen_general_info(const Input_para& inp, const std::time_t start_time, const std::string& stru_file)
 {
 
 #ifdef VERSION
@@ -26,7 +27,6 @@ void gen_general_info(const Parameter& param)
 #endif
 
     // start_time
-    std::time_t start_time = param.globalv.start_time;
     std::string start_time_str;
     convert_time(start_time, start_time_str);
 
@@ -45,27 +45,15 @@ void gen_general_info(const Parameter& param)
 
     AbacusJson::add_json({"general_info", "version"}, version, false);
     AbacusJson::add_json({"general_info", "commit"}, commit, false);
-    AbacusJson::add_json({"general_info", "device"}, param.inp.device, false);
+    AbacusJson::add_json({"general_info", "device"}, inp.device, false);
     AbacusJson::add_json({"general_info", "mpi_num"}, mpi_num, false);
     AbacusJson::add_json({"general_info", "omp_num"}, omp_num, false);
-    AbacusJson::add_json({"general_info", "pseudo_dir"}, param.inp.pseudo_dir, false);
-    AbacusJson::add_json({"general_info", "orbital_dir"}, param.inp.orbital_dir, false);
-    AbacusJson::add_json({"general_info", "stru_file"}, param.globalv.global_in_stru, false);
-    AbacusJson::add_json({"general_info", "kpt_file"}, param.inp.kpoint_file, false);
+    AbacusJson::add_json({"general_info", "pseudo_dir"}, inp.pseudo_dir, false);
+    AbacusJson::add_json({"general_info", "orbital_dir"}, inp.orbital_dir, false);
+    AbacusJson::add_json({"general_info", "stru_file"}, stru_file, false);
+    AbacusJson::add_json({"general_info", "kpt_file"}, inp.kpoint_file, false);
     AbacusJson::add_json({"general_info", "start_time"}, start_time_str, false);
     AbacusJson::add_json({"general_info", "end_time"}, end_time_str, false);
-
-    // AbacusJson::add_Json(version,false,"general_info", "version");
-    // AbacusJson::add_Json(commit,false,"general_info", "commit");
-    // AbacusJson::add_Json(param.inp.device,false,"general_info", "device");
-    // AbacusJson::add_Json(mpi_num,false,"general_info", "mpi_num");
-    // AbacusJson::add_Json(omp_num,false,"general_info", "omp_num");
-    // AbacusJson::add_Json(param.inp.pseudo_dir,false,"general_info", "pseudo_dir");
-    // AbacusJson::add_Json(param.inp.orbital_dir,false,"general_info", "orbital_dir");
-    // AbacusJson::add_Json(param.inp.stru_file,false,"general_info", "stru_file");
-    // AbacusJson::add_Json(param.inp.kpoint_file,false,"general_info", "kpt_file");
-    // AbacusJson::add_Json(start_time_str,false,"general_info", "start_time");
-    // AbacusJson::add_Json(end_time_str,false,"general_info", "end_time");
 }
 #endif
 } // namespace Json

source/source_io/module_json/general_info.h

@@ -1,14 +1,22 @@
 #ifndef GENERAL_INFO_H
 #define GENERAL_INFO_H
-#include "source_io/module_parameter/parameter.h"
+#include <ctime>
+#include <string>
+
+struct Input_para;
 
 /**
 * @brief In this part of the code to complete the general_info part of the json tree.
 */
 namespace Json
 {
 #ifdef __RAPIDJSON
-void gen_general_info(const Parameter& param);
+/**
+ * @param inp: input parameters supplying device, pseudo_dir, orbital_dir and kpoint_file.
+ * @param start_time: when the run started.
+ * @param stru_file: path of the structure file actually read.
+ */
+void gen_general_info(const Input_para& inp, const std::time_t start_time, const std::string& stru_file);
 #endif
 }
-#endif
+#endif

source/source_io/module_json/para_json.cpp

@@ -36,7 +36,7 @@ void json_output()
 void create_Json(UnitCell* ucell, const Parameter& param)
 {
 #ifdef __RAPIDJSON
-    gen_general_info(param);
+    gen_general_info(param.inp, param.globalv.start_time, param.globalv.global_in_stru);
     gen_init(ucell, param.inp);
     // gen_stru(ucell, param.inp);
 #endif