Commit fbbb357
Keep parameter.h inside the macro region in para_json_test.cpp
CI caught what the local build could not: source_io/module_json is only added
with ENABLE_RAPIDJSON, so MODULE_IO_JSON_OUTPUT_TEST was never compiled here.
para_json_test.cpp drives a local `Parameter param;` and writes `param.sys` /
`param.input`. The scoping pass hoisted parameter.h out of the macro region
because its 'does this file write PARAM' test only matched the uppercase
`PARAM.input.` singleton, not a lowercase local object -- the same miss already
fixed for lj_pot_test.cpp. Restored inside the region.
Reproduced and verified on a minimal translation unit: the hoisted arrangement
gives exactly the two 'is private within this context' errors CI reported, and
the restored one compiles clean.
Also drops the relax_criteria.h include from the three headers that do not
name the type (ions_move_bfgs2.h, ions_move_lbfgs.h, lattice_change_basic.h).
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent 517406a commit fbbb357
4 files changed
Lines changed: 1 addition & 4 deletions
File tree
- source
- source_io/module_json/test
- source_relax
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | 3 | | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | 4 | | |
6 | 5 | | |
7 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | 4 | | |
6 | 5 | | |
7 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | 4 | | |
6 | 5 | | |
7 | 6 | | |
| |||
0 commit comments