Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Relax dependency pinning / comment on necessity. #365

Open
JamesOwers opened this issue May 8, 2020 · 3 comments
Open

[Feature] Relax dependency pinning / comment on necessity. #365

JamesOwers opened this issue May 8, 2020 · 3 comments
Labels
enhancement New feature or request feature New feature for Spleeter

Comments

@JamesOwers
Copy link

Description

It's difficult for me to use your software within another project because you've pinned versions of packages (as opposed to specified a minimal requirement).

Resolution

Please may you either relax these specifications in requirements.txt and setup.py e.g. pandas==0.25.1 -> pandas>=0.25.1, or provide a pointer as to why these are required. If I know why they are required, this may really help me fork your project and make edits required to get your software working within mine!

Many thanks!

@JamesOwers JamesOwers added enhancement New feature or request feature New feature for Spleeter labels May 8, 2020
@mmoussallam
Copy link
Collaborator

Hi @JamesOwers

Thanks for the suggestion we'll look into it. We've pinned to specific versions we know for sure are compatible with our code and to avoid getting issues raised each time a dependency breaks something in its API. I guess you can always upgrade them and still use spleeter most of the time.

@JamesOwers
Copy link
Author

Hello @mmoussallam - thanks for your quick response.

Yup, though my issue is that other packages are sometimes requiring a lower version, e.g. of panda, so I was wondering if there were specific features of the newer versions you were relying on.

However, understand this is a pain, and no doubt there is a way of me working round it myself. I'm relatively new to python packaging, so just struggling with adding your package to my install_requires.

@mhsmith
Copy link

mhsmith commented Sep 8, 2020

Yes, libraries shouldn't usually require exact versions of dependencies, because if two libraries both do that, it'll probably be impossible to satisfy both of their requirements at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature New feature for Spleeter
Projects
None yet
Development

No branches or pull requests

3 participants