Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate commitlint component on gitlab #106

Closed
1 task done
Tracked by #92 ...
zachariahmiller opened this issue Oct 16, 2024 · 4 comments
Closed
1 task done
Tracked by #92 ...

Validate commitlint component on gitlab #106

zachariahmiller opened this issue Oct 16, 2024 · 4 comments
Assignees

Comments

@zachariahmiller
Copy link
Contributor

zachariahmiller commented Oct 16, 2024

Issue to port commitlint functionality we use in github to gitlab without regressions in functionality

Tasks

Preview Give feedback
@zachariahmiller
Copy link
Contributor Author

gitlab doesnt have the same triggers as github and as such as it stands today we cannot enable the functionality where when someone changes the title of a PR it will retrigger the commitlint pipeline.

This leaves us with essentially 3 options:

  1. document this shortcoming and try to guide behavior
  2. Build a custom webhook receiver that receives the webhook only merge request events and then executes the commitlint pipeline to run again via api request to the pipelines api.
  3. write a centralized pipeline job/project that runs a a very short schedule and queries all open mrs and re-kicks the commitlint job if its not complaint. This has numerous limitations including limitations in gitlab scheduling using sidekiq for short durations, causes additional compute overhead and overhead on the web service for ci running the checks and still is not remotely close to properly enforcing as there is no actual trigger aside from the schedule.

As such, we will stick with option 1 in the short term and evaluate our options further once we are able to get folks onboarded to using gitlab.

@Racer159
Copy link
Contributor

4th option would be exploring a FaaS solution such as Knative https://knative.dev/docs/ (which may be more flexible for others as well)

@zachariahmiller
Copy link
Contributor Author

4th option would be exploring a FaaS solution such as Knative https://knative.dev/docs/ (which may be more flexible for others as well)

yes which i love as a long term solution with additional value add for our platform!

@zachariahmiller zachariahmiller changed the title Validate commitlint component Validate commitlint component on gitlab Oct 16, 2024
@oates
Copy link
Contributor

oates commented Oct 17, 2024

Agree on going with short term solution 1 for now and getting back to the other solutions post migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants