We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should these fields be made plural to match other fields?
bindle/src/invoice/mod.rs
Lines 79 to 81 in 9487388
IMO we should be listing these as "parcels", "groups", and "signatures" as we're dealing with a list of objects rather than a single object.
That being said, this would break backwards compatibility with older bindle clients.
I noticed this while updating bindle-dotnet to the newest bindle APIs.
The text was updated successfully, but these errors were encountered:
We had it that way originally but changed our minds for a specific reason I can't remember. @technosophos do you remember?
Sorry, something went wrong.
#34
Yeah that is where we changed it, but we had an "in person" discussion about why we were doing it
No branches or pull requests
Should these fields be made plural to match other fields?
bindle/src/invoice/mod.rs
Lines 79 to 81 in 9487388
IMO we should be listing these as "parcels", "groups", and "signatures" as we're dealing with a list of objects rather than a single object.
That being said, this would break backwards compatibility with older bindle clients.
I noticed this while updating bindle-dotnet to the newest bindle APIs.
The text was updated successfully, but these errors were encountered: