Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

hippo commands without config returns unintuitive error #117

Open
bacongobbler opened this issue Mar 31, 2022 · 3 comments
Open

hippo commands without config returns unintuitive error #117

bacongobbler opened this issue Mar 31, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@bacongobbler
Copy link
Contributor

bacongobbler commented Mar 31, 2022

When hippo isn't running:

><> hippo app add helloworld helloworld
Error: error in reqwest: error sending request for url (https://localhost:5309/api/app): error trying to connect: tcp connect error: Connection refused (os error 111)

With insecure TLS:

><> hippo app add helloworld helloworld
Error: error in reqwest: error sending request for url (https://localhost:5309/api/app): error trying to connect: error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed:../ssl/statem/statem_clnt.c:1914: (self signed certificate)

Should probably be:

hippo app add helloworld helloworld
Error: No configuration file found. Please log in using `hippo login`
@bacongobbler bacongobbler added the enhancement New feature or request label Mar 31, 2022
@itowlson
Copy link
Contributor

I don't know enough to be sure, but "No configuration file found" may be an implementation detail. Might it be better to say "Not logged in. Please log in..."?

You could still put "No configuration file found" in the logs in case someone is trying to diagnose why they are not logged in.

@bacongobbler
Copy link
Contributor Author

bacongobbler commented Mar 31, 2022

The reason I didn't go with "not logged in" is because bindle has a feature flag where you don't need to log in at all (bindle-server --unauthenticated), so I thought that may be a bit confusing if the user disabled authentication. But I do agree that the error message describes internal implementation details... Hmm.

@itowlson
Copy link
Contributor

And the message says "Please log in" grin

"Your Bindle configuration is not, er. configured. Please, er, configure it," or something like that? riffles frantically through thesaurus

@bacongobbler bacongobbler changed the title hippo push without config returns unintuitive error hippo commands without config returns unintuitive error Apr 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants