Skip to content
This repository has been archived by the owner on Feb 21, 2024. It is now read-only.

implement kubectl logs #1

Open
bacongobbler opened this issue May 21, 2020 · 3 comments
Open

implement kubectl logs #1

bacongobbler opened this issue May 21, 2020 · 3 comments

Comments

@bacongobbler
Copy link

All of the infrastructure is in place for kubectl logs. We just need a way to hook output_writer into the wasm3 runtime such that the output of the function call will be written to disk. Right now the output is only written to standard output.

_output_write: std::fs::File, //TODO: hook this up such that log output will be written to the file

@bacongobbler
Copy link
Author

wasm3/wasm3#147

@vshymanskyy
Copy link

@bacongobbler could you please elaborate on those questions:

Now the bigger question is, how this redirection should be implemented API-wise?
Would the Wasm3 library user need to register read/write callbacks?
Should they handle the iovec logic on their side, or should it be abstracted away?

We're considering to add ability to redirect IO, but would better understand the level of flexibility needed.

@vshymanskyy
Copy link

I.e. redirecting to a file descriptor is one thing, providing callbacks/hooks is different.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants