Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy icons that aren't just... you know... coloured circles #12

Open
itowlson opened this issue Dec 3, 2019 · 3 comments
Open

Policy icons that aren't just... you know... coloured circles #12

itowlson opened this issue Dec 3, 2019 · 3 comments
Assignees

Comments

@itowlson
Copy link
Contributor

itowlson commented Dec 3, 2019

Coloured circles is all I got.

@flynnduism
Copy link
Member

Will do @itowlson!

Looking at OPA's design collateral, they don't really have any icons to represent the different types/states... From their site and docs, they use a normal kubernetes icon for denoting a kubernetes-centrkc policy as far as I can tell. From this repo am I correct in thinking that the different icons needed are as follows:

type
 - policy (.rego)
 - data (not .rego)
state
 - ok
 - error
 - unknown 

Simple OPA logo icons

Screen Shot 2020-01-02 at 12 45 36 PM

First approach is only showing an OPA state, based off the logo.

Policy Type icons

To show the policy type as well, it gets a bit more abstract. I've used a shield to denote whether it is a .rego policy or not:

Screen Shot 2020-01-02 at 12 45 28 PM

or:

Screen Shot 2020-01-02 at 12 45 24 PM


Do these fit what you're seeking?

@flynnduism
Copy link
Member

@itowlson do you have a preferred direction from the above icon styles?

I will cut these up and add them to the extension accordingly.

@itowlson
Copy link
Contributor Author

itowlson commented Feb 4, 2020

Oops sorry I missed that you had already done this! That's the last time I take a holiday sigh...

You are correct about the states being okay / error / unknown. Emma from the Gatekeeper team suggested that we should distinguish these with shape not just colour for accessibility, and I don't think the current proposals will meet that excellent recommendation on their own. She suggested a tick or cross to indicate status, but very much open to ideas.

The other axis however is not policy-vs-not-policy but the slightly subtle one of whether the policy is 'managed' by the VS Code extension. That is, was the policy deployed into OPA using the VS Code extension, or was it deployed manually by some other means. This affects whether we treat it as 'part of the current dev workflow' and therefore whether we confirm on update or delete or whether the policy participates in workspace sync. Again, not sure how to represent this, but one idea could be to overlay a small VS Code lazy-8 icon on the 'managed' ones...?

Hope that makes sense!

I like the OPA helmet icons but am not sure how they will look at tree icon size. The simpler, bolder shape of the shield outline may work better, or the helmet could also be good in outline or otherwise simplified... thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants