You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 22, 2024. It is now read-only.
With #39, the default behavior of None for allowed_hosts changes from allowing guest modules to make requests to any server to not allowing access to any server.
Additionally, if someone intends to allow access to all subdomains of a particular domain, that is currently impossible, and each subdomain would have to be individually added to the list.
Do we want to add:
A top-level wildcard that would explicitly allow guest modules to send requests to all servers? Perhaps "*" as the only element of the allowed_hosts vector?
The ability to specify a domain wildcard?
The text was updated successfully, but these errors were encountered:
*.example.com should not match example.com, though (typicallygithub.io and user-controlled subdomains would require different capabilities), which can be a bit counter-intuitive if we use the wildcard syntax.
But if all we want to an allowlist, this is probably the easiest way to go.
That being said, no matter if they fail open or close, virtually all ACL systems have both allow and deny lists. Not doing so quickly ends up with limitations (ex in that case: all example.com subdomains are fine, but not admin.example.com or www.example.com).
I'm not sure that capabilities modeled after descriptors can be extended to host or domain names without being quickly painful to use in actual applications.
This would be very useful feature. Im creating a thing that needs to connect to lots of different subhosts like ab-cd.sub.host.com, ac-dc.sub.host.com etc where the first part may change.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
With #39, the default behavior of
None
forallowed_hosts
changes from allowing guest modules to make requests to any server to not allowing access to any server.Additionally, if someone intends to allow access to all subdomains of a particular domain, that is currently impossible, and each subdomain would have to be individually added to the list.
Do we want to add:
allowed_hosts
vector?The text was updated successfully, but these errors were encountered: