Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call to "zfs list" in "apply" script doesn't work when run from appliance-build #43

Open
prakashsurya opened this issue Jan 28, 2019 · 0 comments

Comments

@prakashsurya
Copy link
Contributor

In the apply script, we execute the following logic:

ROOT_FILESYSTEM=$(zfs list -Ho name /)

The problem is we run this script from appliance-build, where the / filesystem isn't a ZFS filesystem:

+ ./binary/var/lib/delpix-platform/ansible/apply
'/': not a ZFS filesystem

Specifically, at that point, / maps to the build system's root filesystem rather than the root filesystem of the appliance build generated.

Thus, the fact that the build currently works is entirely coincidental, rather than working as designed. We should fix this before this problem results in incorrect behavior, rather than the current benign error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant