Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Member left" should be marked as read automatically #5689

Closed
link2xt opened this issue Jun 13, 2024 · 2 comments
Closed

"Member left" should be marked as read automatically #5689

link2xt opened this issue Jun 13, 2024 · 2 comments
Labels
bug Something is not working

Comments

@link2xt
Copy link
Collaborator

link2xt commented Jun 13, 2024

Since #5629 chats are not sorted to the top when someone leaves the group, but message is marked as unread. On desktop this results in the badge constantly saying that I have 1 unread message, but it is difficult to find the chat which has unread message because it is somewhere in the chatlist not close to the top.

@link2xt link2xt added the bug Something is not working label Jun 13, 2024
@iequidoo
Copy link
Collaborator

iequidoo commented Jun 13, 2024

No, it was suggested in #5618 not to sort the chat up on a "group left" message, but it's not implemented in #5629 because, citing myself

If i added someone to a group then it may be interesting to me that they have left the group.

, so i'd suggest at least to check who added the member to the group, but this is not always possible because the member may be "synced in" by the group membership consistency algo (so the member could be added even by user's other device) or because of ephemeral messages enabled.

So, i'm not sure the bug you described is related to the above PR even if you compiled your Desktop with it.

@link2xt
Copy link
Collaborator Author

link2xt commented Jun 17, 2024

Not sure what happened because I was not running #5618
Let's close this for now.

@link2xt link2xt closed this as not planned Won't fix, can't repro, duplicate, stale Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

No branches or pull requests

2 participants