Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close iroh endpoing when stop_io() is called #6250

Closed
link2xt opened this issue Nov 23, 2024 · 5 comments
Closed

Close iroh endpoing when stop_io() is called #6250

link2xt opened this issue Nov 23, 2024 · 5 comments
Assignees
Labels
bug Something is not working

Comments

@link2xt
Copy link
Collaborator

link2xt commented Nov 23, 2024

iOS is unhappy about open sockets when the app goes to background, including seemingly bound UDP sockets.

Instead of storing Endpoint in OnceCell, we should store it behind RwLock and Option:

pub(crate) iroh: OnceCell<Iroh>,

Probably when I/O is restarted back we should restore the key and rejoin gossip, but as a first step we should drop everything and generate a new key each time I/O is restarted.

@link2xt link2xt added the bug Something is not working label Nov 23, 2024
@link2xt link2xt self-assigned this Nov 25, 2024
@Septias
Copy link
Collaborator

Septias commented Nov 26, 2024

I can also do this if you want

@r10s
Copy link
Member

r10s commented Nov 26, 2024

it is already in progress at #6264

@Septias
Copy link
Collaborator

Septias commented Nov 26, 2024

ah, didn't see the related PR

@gerryfrancis
Copy link
Contributor

Now that #6264 has been merged, this issue should be closed, right?

@link2xt
Copy link
Collaborator Author

link2xt commented Nov 29, 2024

Closed by #6264

@link2xt link2xt closed this as completed Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

No branches or pull requests

4 participants