fix: Change BccSelf default to 0 for chatmail (#6340) #6344
Conversation
src/config.rs
Outdated
| Config::ConfiguredInboxFolder => Some("INBOX"), | ||
| Config::DeleteServerAfter => { | ||
| match Box::pin(self.get_config(Config::BccSelf)).await?.as_deref() { | ||
| Some("0") => Some("1"), |
There was a problem hiding this comment.
A check for IsChatmail is forgotten
There was a problem hiding this comment.
Though it's an interesting question -- is leaving emails on the server useful w/o BccSelf? Probably not for most email providers because outgoing messages would be missing anyway. But to keep the current behaviour a check for IsChatmail should be added. Also other MUAs don't delete emails from the server by default even if the server doesn't save sent messages to some sentbox (like Gmail does)
EDIT: Fixed and added a test on the default DeleteServerAfter behaviour.
Change `BccSelf` default to 0 for chatmail configurations and enable it upon a backup export. As for `DeleteServerAfter` who was set to 0 upon a backup export before, make its default dependent on `BccSelf` for chatmail. We don't need `BccSelf` for chatmail by default because we assume single-device use. Also `BccSelf` is needed for "classic" email accounts even if `DeleteServerAfter` is set to "immediately" to detect that a message was sent if SMTP server is slow to respond and connection is lost before receiving the status line which isn't a problem for chatmail servers.
iequidoo
force-pushed
the
iequidoo/0-bcc_self-for-chatmail
branch
from
dc4dcf4 to
a900800
Compare
|
Let's say someone has created a chatmail account before this change. They have no Then they update Delta Chat. Now EDIT: ignore, did not notice the migration |
Fix #6340