Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set send-copy-to-self to off, when delete-immediately-after-download is on #6340

Closed
hpk42 opened this issue Dec 13, 2024 · 4 comments · Fixed by #6344
Closed

Set send-copy-to-self to off, when delete-immediately-after-download is on #6340

hpk42 opened this issue Dec 13, 2024 · 4 comments · Fixed by #6344
Assignees
@iequidoo
Labels
bug Something is not working

Comments

@hpk42
Copy link
Contributor

hpk42 commented Dec 13, 2024

by default, users on chatmail servers onboard in "single device" mode and all messages are immediately removed after download. Effectively, send-copy-to-self is ignored but it should be actually off (and turned on, when multi-device is turned on, and the delete-mode changes to automatic). See also https://support.delta.chat/t/local-chat-in-delta-chat/3294/10
@hpk42 hpk42 added the bug Something is not working label Dec 13, 2024
@link2xt
Copy link
Collaborator

link2xt commented Dec 13, 2024 •
edited
Loading

On Android "Send copy to self" setting is not even visible for chatmail profiles. DeleteServerAfter defaults to "at once" and then changed to 0 ("Automatic" in Android UI) when backup is exported.

@adbenitez
Copy link
Member

adbenitez commented Dec 13, 2024 •
edited
Loading

this behavior is intentional, sending copy to self can help in an slow network identify if a "big" outgoing message was actually already delivered and we just didn't get the response from server due to timeout, in such cases core will then mark message as sent and not keep retrying (and failing) to send over and over

that is why we send copy to self even if "delete at once" is enabled

@link2xt
Copy link
Collaborator

link2xt commented Dec 13, 2024

Indeed, I forgot that 2faf7fd removed the logic which disabled BccSelf when DeleteServerAfter is immediate.

Chatmail servers don't have this timeout problem so sending to self and immediately deleting there does not make much sense.

Maybe we should rework the logic to have BccSelf disabled by default and enabled when exporting backup, and DeleteServerAfter=0 should be the default for every profile (chatmail or not) but for chatmail treated as "immediate" if BccSelf is off.

@iequidoo
Copy link
Collaborator

Maybe we should rework the logic to have BccSelf disabled by default and enabled when exporting backup

IIUC only for chatmail accounts (otherwise with defaults, for "classic" mail accounts users may have this "timeout problem" with big outgoing messages).

and DeleteServerAfter=0 should be the default for every profile (chatmail or not) but for chatmail treated as "immediate" if BccSelf is off.

Currently DeleteServerAfter is None by default and i think it's fine to leave this as is, but indeed it may be treated differently depending on IsChatmail and BccSelf.

@iequidoo iequidoo self-assigned this Dec 16, 2024
iequidoo added a commit that referenced this issue Dec 17, 2024
@iequidoo
fix: Change BccSelf default to 0 for chatmail (#6340)
dc4dcf4 
Change `BccSelf` default to 0 for chatmail configurations and enable it upon a backup export. As for
`DeleteServerAfter` who was set to 0 upon a backup export before, make its default dependent on
`BccSelf` for chatmail. We don't need `BccSelf` for chatmail by default because we assume
single-device use. Also `BccSelf` is needed for "classic" email accounts even if `DeleteServerAfter`
is set to "immediately" to detect that a message was sent if SMTP server is slow to respond and
connection is lost before receiving the status line which isn't a problem for chatmail servers.
@iequidoo iequidoo mentioned this issue Dec 17, 2024
Merged
iequidoo added a commit that referenced this issue Dec 17, 2024
@iequidoo
fix: Change BccSelf default to 0 for chatmail (#6340)
a900800 
Change `BccSelf` default to 0 for chatmail configurations and enable it upon a backup export. As for
`DeleteServerAfter` who was set to 0 upon a backup export before, make its default dependent on
`BccSelf` for chatmail. We don't need `BccSelf` for chatmail by default because we assume
single-device use. Also `BccSelf` is needed for "classic" email accounts even if `DeleteServerAfter`
is set to "immediately" to detect that a message was sent if SMTP server is slow to respond and
connection is lost before receiving the status line which isn't a problem for chatmail servers.
iequidoo added a commit that referenced this issue Dec 28, 2024
@iequidoo
fix: Change BccSelf default to 0 for chatmail (#6340)
2166412 
Change `BccSelf` default to 0 for chatmail configurations and enable it upon a backup export. As for
`DeleteServerAfter` who was set to 0 upon a backup export before, make its default dependent on
`BccSelf` for chatmail. We don't need `BccSelf` for chatmail by default because we assume
single-device use. Also `BccSelf` is needed for "classic" email accounts even if `DeleteServerAfter`
is set to "immediately" to detect that a message was sent if SMTP server is slow to respond and
connection is lost before receiving the status line which isn't a problem for chatmail servers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iequidoo iequidoo

Labels
bug Something is not working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Change BccSelf default to 0 for chatmail (#6340) deltachat/deltachat-core-rust
4 participants
@hpk42 @link2xt @adbenitez @iequidoo