Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disappearing messages are not disappearing #6360

Closed
link2xt opened this issue Dec 22, 2024 · 6 comments · Fixed by #6365
Closed

Disappearing messages are not disappearing #6360

link2xt opened this issue Dec 22, 2024 · 6 comments · Fixed by #6365
Assignees
Labels
bug Something is not working

Comments

@link2xt
Copy link
Collaborator

link2xt commented Dec 22, 2024

There is a report of non-disappearing "disappearing messages" in #6355
The issue is closed because it essentially consisted of two issues, but disappearing messages problem is still unsolved

@kdltr has cases where in active chats some messages do not disappear even though they are read. Message info contains "Ephemeral timer: 604800" and "Expires: 2024.12.29 10:45:46" lines as if the timer started just now and will expire in 7 days.

The reason why the timer is not started is unclear, but the problem may be that the message was not actually marked as read by any UI. We should start the timer for all messages when the message is marked as noticed to make this more reliable. This way just opening a chat or marking any message as seen from another device should be enough to start the timer for all messages in a chat.

@link2xt link2xt added the bug Something is not working label Dec 22, 2024
@r10s
Copy link
Member

r10s commented Dec 23, 2024

This way just opening a chat or marking any message as seen from another device should be enough to start the timer for all messages in a chat.

reason for staring the counter only for actually seen messages might be that that we have comparable short timeouts (1 minute, not long ago even 30 seconds) -- not sure about the usecases of these short timeouts, maybe fine also with start-ephemeral-timer-on-noticed (== start-ephemeral-timer-opening-chat), just saying

sending read receipts should not be touched and stay on-mark-seen (== really displayed on the screen), at least at a first glance.

@r10s
Copy link
Member

r10s commented Dec 23, 2024

not sure about the usecases of these short timeouts

the settings might have been inspired by signal, also having 30 seconds and 1 minute. telegram and whatsapp have minimums of 1 day

@link2xt
Copy link
Collaborator Author

link2xt commented Dec 23, 2024

Fix is at #6365

@iequidoo
Copy link
Collaborator

or marking any message as seen from another device should be enough to start the timer for all messages in a chat.

Couldn't find any code marking a chat or older messages as noticed if a chat message has been seen on another device.

@iequidoo
Copy link
Collaborator

Still, we don't start ephemeral timers when messages are noticed on another device and when DC_CHAT_ID_ARCHIVED_LINK is marked as noticed, isn't it a problem?

@link2xt
Copy link
Collaborator Author

link2xt commented Dec 24, 2024

Opened follow-up PR #6367

Also opened an issue #6368 but it's not that important, read synchronization may not work anyway and if the chat has unnoticed messages and a badge with a number then it is expected that the timer did not start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants