Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check code handling invitelinks in core1.150.0 #4363

Closed
r10s opened this issue Nov 27, 2024 · 1 comment
Closed

check code handling invitelinks in core1.150.0 #4363

r10s opened this issue Nov 27, 2024 · 1 comment
Labels
blocker This issue is blocking a new release

Comments

@r10s
Copy link
Member

r10s commented Nov 27, 2024

since core 1.150.0 with deltachat/deltachat-core-rust#6223, dc_get_securejoin_qr() returns an invite link directly instead of OPENPGP4FPR:....

this means, conversions to create invitelinks from OPENPGP4FPR:... are superfluous and may be harmful (eg. android results in a double prefix, on iOS an error was returned).

instead, desktop can share/copy the value of dc_get_securejoin_qr() without modifcations.
@r10s r10s added the blocker This issue is blocking a new release label Nov 27, 2024
@r10s
Copy link
Member Author

r10s commented Nov 27, 2024 •
edited
Loading

ftr, this is the corresponding Android/iOS code: deltachat/deltachat-ios#2420 / deltachat/deltachat-android#3454

nicodh added a commit that referenced this issue Nov 27, 2024
@nicodh
Skip unnecessary invite code conversion
c6615e6 
resolves #4363
@nicodh nicodh mentioned this issue Nov 28, 2024
Merged
@nicodh nicodh closed this as completed in 20fcb35 Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker This issue is blocking a new release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@r10s