cancelling profile creation with "Esc" not fully working

[r10s]

when cancelling profile creation with the "Back Arrow", the dialog is closed, the account in creation is removed, and one is back in the last profile - all as expected.

however, using the "Esc" key instead, the account in creation is not removed and one is not back in the last profile. also the dialog is only removed partly, the background images stays:

weirdly, the dialog comes back when the window is resized

[WofWca]

I did some debugging. Looks like on first Esc press it invokes onCancel, which gets prevented, but the second Esc press invokes onCancel and onClose. And onClose does close dialog.

deltachat-desktop/packages/frontend/src/components/Dialog/Dialog.tsx

Lines 61 to 70 in 1abfd30

	const onClose = (value: any) => {
	props.onClose && props.onClose(value)
	dialog.current!.style.display = 'none'
	}
	const onCancel = (ev: React.BaseSyntheticEvent) => {
	if (!canEscapeKeyClose) {
	ev.preventDefault()
	}
	}

Answers here https://stackoverflow.com/questions/61021135/prevent-dialog-from-closing-on-keydown-esc-in-chrome indicate that this is a Chromium thing.

So this affects all dialogs that use canEscapeKeyClose={false}.

Let's consider handling onClose in such cases, and closing the dialog, if the users wants it so bad. In this case this would be calling onExitWelcomeScreen.

[WofWca]

I discovered that on the second cancel event ev.cancelable === false, unlike on the first one.

Another hack I can suggest is to dialogRef.current.showModal() immediately after such an event.

[WofWca]

Oh, and another thing: maybe we shouldn't utilize showModal for such un-closable dialogs at all? Looks like we only want showModal for the backdrop:

deltachat-desktop/packages/frontend/src/components/Dialog/Dialog.tsx

Lines 73 to 75 in 5e07d5e

	// calling showModal is "only" the way to have ::backdrop
	dialog.current?.showModal()
	dialog.current!.style.display = 'flex'

But I guess we still want other contents to be non-interactive for such dialogs, so IDK...

[WofWca]

Let's reopen to track other such dialogs as suggested in #4396 (review)

[nicodh]

Closing since the bug is fixed. Followup is here: #4397