Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pasting image from clipboard doesn't work on Desktop #4393

Open
ell1e opened this issue Dec 7, 2024 · 7 comments
Open

Pasting image from clipboard doesn't work on Desktop #4393

ell1e opened this issue Dec 7, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@ell1e
Copy link

ell1e commented Dec 7, 2024

"Scan QR Code" > "Paste from clipboard" doesn't seem to work if the clipboard contains the image, only if it contains an invite URL. I would also propose that the desktop client continuously checks if the clipboard contains a QR code, and prompts the user to import a new contact if any such QR code was copied as an image or as an URL. I've had users almost give up on desktop trying to navigate the 4 or 5 clicks trying to import an URL or an image, it seems like it's confusing them since without a camera it doesn't seem sufficiently natural to do.

  • Operating System (Linux/Mac/Windows/iOS/Android): all desktop operating systems
  • Delta Chat Version: 1.48.0 Desktop (git: flathub), v1.148.7 core
  • Expected behavior: "Paste from clipboard" works on QR code images in clipboard, and perhaps is automatically prompted for user when something in the clipboard is detected
  • Actual behavior: "Paste from clipboard" seems to only work on invite URLs but not QR code images in clipboard, and always needs to be manually invoked
  • Steps to reproduce the problem: Copy a QR code image e.g. somebody sent you via some other messenger on desktop, via "Copy image". After that, the remaining steps to get Delta Chat Desktop to do something with it are relatively arcane.
  • Screenshots:
  • Logs:
@r10s r10s added the enhancement New feature or request label Dec 7, 2024
@r10s
Copy link
Member

r10s commented Dec 7, 2024

I would also propose that the desktop client continuously checks if the clipboard contains a QR code

at least some OS and user will regard that as bad behaviour. clipboard should only be accessed on direct user action.

to the main issue:

note, that the recommended way is to pass invite-links around, which is usually much easier and also better supported cross-platform.

support for sending images with QR codes around is regarded unsupported, advanced workflow and also not supported on all platforms equally.

that said, well, i am not deep in the desktop code. if desktop-devs regard it as easy enough to alllow pasting of images, and it does not make the mainly supported workflows significantly harder to maintain, it probably makes sense to consider adding that feature.

in general, however, feature requests should go to the https://support.delta.chat

@ell1e
Copy link
Author

ell1e commented Dec 8, 2024

and also not supported on all platforms equally.

Mobile usually has the cameras for the normal scanning workflow. So this pasting image problem would probably primarily come up on desktop.

After some pondering, I filed a bug since I saw multiple desktop users run into this barrier and need a ton(!) of hand-holding to get past it. Whatever is done to address it, I don't think users currently know how to deal with this issue so the UI doesn't really seem to be working. Sorry if that was a bad choice.

As for links, it's not obvious on the inviting person's end that this would be needed to make this work better. The UI lets me either share an image or a link without really encouraging either. So therefore, pasting either should probably work.

There might be other ways to reduce the barriers on desktop, like for example scanning the clipboard. I'm sure others might have better ideas. But the amount of clicks and pasting quirks seem like a problem. I hoped to provide a constructive ticket to support improving the situation.

@r10s
Copy link
Member

r10s commented Dec 8, 2024

Mobile usually has the cameras for the normal scanning workflow. So this pasting image problem would probably primarily come up on desktop.

mobile has similar issue if ppl are not sitting next to each other, this is what the invite links were created for

As for links, it's not obvious on the inviting person's end that this would be needed to make this work better

ftr, android spearheaded some changes recently to make links more accessible, changes were done in feedback with users, eg. deltachat/deltachat-android#3367 (comment)

"copy image" is tuned down on purpose, highlighting supported flows.

surely, that can be improved further, and also things are not finished, desktop/ios is mostly unchanged. also there are old versions around

as said, from view of user, pasting images is probably fine. however, eg. i am critical in offering copying images more prominently atm, as that would easily increase more dead ends atm -- but this is also not what this issue is about :)

I hoped to provide a constructive ticket to support improving the situation.

you did ❤️ this is very welcome! i just want to add some context about priorities and thelike :)

btw, pasting - may it be link or image - could also work outside the scan-dialog, this would make lots more clicks superfluous

@ell1e
Copy link
Author

ell1e commented Dec 8, 2024

I don't think making copying the image or the link has to be similarly trivial, since users who want to do that likely have been DeltaChat for a while already and therefore should have more patience.

btw, pasting - may it be link or image - could also work outside the scan-dialog, this would make lots more clicks superfluous

I like this idea, as long as some new paste dialog would ask whether one would want to add the user or just normally paste into the chat input, such that sending the links around via DeltaChat itself remains available.

After some deliberation I would also like to suggest moving the load or paste button into a more symmetrical position to the copy button:

(WHAT FOLLOWS IS A MOCKUP IMAGE THAT I EDITED)
Screenshot_20241208_125133
(ABOVE THIS LINE IS A MOCKUP IMAGE THAT I EDITED)

@nicodh
Copy link
Contributor

nicodh commented Dec 8, 2024

I tried it with the flathub version 1.48.0 and it is working as expected! Maybe there is something else wrong in the scenario?

FYI: we changed this screen in the upcoming version to look like this:

image

In the upcoming version you still can paste an image of a QR scan when clicking on "Paste". The menu item behind the small settings icon "Load QR COde as image" is stille there and works. But in general it is recommended to got with URLs as @r10s mentioned.

Edit: I see a different screen in my flathub instance, there is no line "Load or paste". Are you sure with the mentioned version?

I have:

Delta Chat Desktop 1.48.0 (git: flathub)
Delta Chat Core v1.148.7
SQLite 3.45.3
electron 32.1.0
node 20.17.0

@ell1e
Copy link
Author

ell1e commented Dec 8, 2024

The "Load or paste" was a mockup of mine as a suggestion, sorry that I was unclear!

Regarding the functionality, often when I do "Copy Image" in firefox and then paste in DeltaChat, nothing seems to happen. I recorded this just now:

100_5660.webm

Sorry for the shaky video, due to some other bug, KDE screen recording seems to be not working right now.

@nicodh
Copy link
Contributor

nicodh commented Dec 8, 2024

So since we changed that part anyway maybe it's the best to wait for the upcoming release. Meanwhile you might check the previews: https://download.delta.chat/desktop/v1.49.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants