fix: chat not being scrolled to bottom (images) #4406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/fix-images-layout-shift
branch
from
5bb3710 to
af0c8a4
Compare
Closes #4404. The bug was introduced in db83279. Prior to that all attachments had a fixed height of 200px. This should also eliminate layout shifting when scrolling the chat, and when new messages arrive. An alternative solution that would still have layout shifting, but at least keep the chat "anchored" to bottom would be #3753 (comment), but it's not supported well by browsers. Co-authored-by: Max Philippov <[email protected]>
WofWca
force-pushed
the
wofwca/fix-images-layout-shift
branch
from
af0c8a4 to
1d2508f
Compare
|
Wait, looks like this adds unnecessary padding for big images:
|
nicodh
approved these changes
Dec 12, 2024
| return { | ||
| height: | ||
| message.dimensionsHeight > 0 && message.dimensionsHeight < 100_000 | ||
| ? message.dimensionsHeight |
There was a problem hiding this comment.
why we have a limit of 100_000 here? Would 10_000 not be enough?
There was a problem hiding this comment.
Probably. But it's just a sanity check.
There was a problem hiding this comment.
Maybe someone has 4 4K monitors stacked on top of each other on their wall 🤷♀️
|
nicodh
requested changes
Dec 12, 2024
|
OK, I'll close this and let's continue the discussion in the relevant issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4404.
The bug was introduced in db83279.
Prior to that all attachments had a fixed height of 200px.
This should also eliminate layout shifting when scrolling the chat,
and when new messages arrive.
An alternative solution that would still have layout shifting,
but at least keep the chat "anchored" to bottom would be
#3753 (comment),
but it's not supported well by browsers.
I tested it, and verified that images have proper dimensions now even before they get displayed, and that it wasn't the case prior to this MR.