Skip to content

create_data_profile options unneeded #170

@thorrester

Description

@thorrester
 #[pyo3(signature = (data, data_type=None, bin_size=20, compute_correlations=false))]
    #[instrument(skip_all)]
    pub fn create_data_profile<'py>(
        &mut self,
        py: Python<'py>,
        data: &Bound<'py, PyAny>,
        data_type: Option<&DataType>,
        bin_size: Option<usize>,
        compute_correlations: Option<bool>,
    ) -> Result<DataProfile, DataProfileError> {

should be

 #[pyo3(signature = (data, data_type=None, bin_size=20, compute_correlations=false))]
    #[instrument(skip_all)]
    pub fn create_data_profile<'py>(
        &mut self,
        py: Python<'py>,
        data: &Bound<'py, PyAny>,
        data_type: Option<&DataType>,
        bin_size: usize,
        compute_correlations: bool,
    ) -> Result<DataProfile, DataProfileError> {

there's not need for option here since the pyo3 signature already specifies defaults

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions