You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
A clear and concise description of what the bug is.
Using the default cheatsheets, the curl examples are broken in zsh for some URLs.
To Reproduce
Steps to reproduce the behavior:
Install Navi
Activate via ctrl+g and install 'default cheatsheets' (/pat/to/navi repo add denisidoro/cheats)
Press ctrl+g again and type curl
Choose send a get http request
Paste a URL such as https://github.com/denisidoro/navi/blob/master/docs/installation.md#installing-the-shell-widget into the variable
The resulting command in the terminal will be curl https://github.com/denisidoro/navi/blob/master/docs/installation.md#installing-the-shell-widget
Executing this command fails with the error zsh: no matches found: https://github.com/denisidoro/navi/blob/master/docs/installation.md#installing-the-shell-widget
Expected behavior
A clear and concise description of what you expected to happen.
Executing the command curl 'https://github.com/denisidoro/navi/blob/master/docs/installation.md#installing-the-shell-widget' succeeds, so it looks like a quoting issue.
Parameters that contain special characters should be quoted automaticaly.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
This is likely to shell-specific, and might be difficult to implement. However it really limits the usefulness of the tool if we need to manually go back in and add quotes around specific parameters.
The text was updated successfully, but these errors were encountered:
Thanks for opening your first issue here! In case you're facing a bug, please update navi to the latest version first. Maybe the bug is already solved! :)
Are you open to making a pr for this?
It would simply be a case of changing the curl.cheat file.
# send a get http request
curl <url>
to
# send a get http request
curl "<url>"
The repo is a community cheat sheet, so prs are welcome.
Putting quotes around the string, will not break the command for other OSs / shells (it's actually better practice). So it's safe to change the cheat sheet globally.
Describe the bug
A clear and concise description of what the bug is.
Using the default cheatsheets, the curl examples are broken in zsh for some URLs.
To Reproduce
Steps to reproduce the behavior:
/pat/to/navi repo add denisidoro/cheats
)curl
send a get http request
https://github.com/denisidoro/navi/blob/master/docs/installation.md#installing-the-shell-widget
into the variablecurl https://github.com/denisidoro/navi/blob/master/docs/installation.md#installing-the-shell-widget
zsh: no matches found: https://github.com/denisidoro/navi/blob/master/docs/installation.md#installing-the-shell-widget
Expected behavior
A clear and concise description of what you expected to happen.
Executing the command
curl 'https://github.com/denisidoro/navi/blob/master/docs/installation.md#installing-the-shell-widget'
succeeds, so it looks like a quoting issue.Parameters that contain special characters should be quoted automaticaly.
Screenshots
If applicable, add screenshots to help explain your problem.
N/A
Versions:
Additional context
Add any other context about the problem here.
This is likely to shell-specific, and might be difficult to implement. However it really limits the usefulness of the tool if we need to manually go back in and add quotes around specific parameters.
The text was updated successfully, but these errors were encountered: