Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): don't use global cache paths for scope allocation #24353

Merged
merged 2 commits into from
Jun 28, 2024
Merged

fix(lsp): don't use global cache paths for scope allocation #24353

merged 2 commits into from
Jun 28, 2024

Conversation

nayeemrmn
Copy link
Collaborator

Fixes #24342. It's very complex to test but I've verified that the repro works and file referrers are allocated correctly.

dsherret
dsherret approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nayeemrmn nayeemrmn merged commit 2ddae87 into denoland:main Jun 28, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-npm-global-cache-file-referrer branch June 28, 2024 17:19
@nayeemrmn nayeemrmn mentioned this pull request Jun 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@nathanwhit nathanwhit Awaiting requested review from nathanwhit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

React helmet async breaking in 1.44.3
2 participants
@nayeemrmn @dsherret