Skip to content
Merged
Show file tree
Hide file tree
Changes from 29 commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
801042c
upgrade
devsnek Sep 3, 2025
f78c9bf
Merge branch 'main' into upgrade
bartlomieju Sep 3, 2025
0f1eb76
some small progress
bartlomieju Sep 3, 2025
dcc7c19
bump v8
bartlomieju Sep 5, 2025
ce10b6b
fix
bartlomieju Sep 5, 2025
67fa229
revert
bartlomieju Sep 5, 2025
f6879b3
actual fixes
bartlomieju Sep 5, 2025
63b1a74
don't lint on Windows for the time being
bartlomieju Sep 5, 2025
dfbcb7e
turn off debug symbols
bartlomieju Sep 6, 2025
c1d78e8
Try again
bartlomieju Sep 6, 2025
310ff73
again
bartlomieju Sep 6, 2025
3f60a84
limit no of jobs
bartlomieju Sep 8, 2025
6c2f1c8
reset CI
bartlomieju Sep 8, 2025
0d27b74
always run cargo clean on windows
bartlomieju Sep 8, 2025
99fa977
disable debug info altogether
bartlomieju Sep 8, 2025
3defca6
Try to use windows-2025 image
bartlomieju Sep 8, 2025
307cf5c
Try setting `/PDBPAGESIZE`
littledivy Sep 8, 2025
4ec8429
-Csymbol-mangling-version=v0
littledivy Sep 8, 2025
4b5108c
fmt
littledivy Sep 8, 2025
fbc786d
try to only test tests
bartlomieju Sep 8, 2025
f3dc0b2
try -Ctarget-feature=+crt-static
ry Sep 8, 2025
180a31a
try /DEBUG:NONE
littledivy Sep 8, 2025
48d6e02
x
littledivy Sep 8, 2025
0a63853
try xl image
bartlomieju Sep 8, 2025
5a1ea0b
x
littledivy Sep 8, 2025
fab6974
use 2022-xl
bartlomieju Sep 8, 2025
8d9f90c
use 2022-xl 2
bartlomieju Sep 8, 2025
d875bd8
update expected output
bartlomieju Sep 8, 2025
7f2e8f5
update expected output
bartlomieju Sep 8, 2025
32cdfa9
revert changes
bartlomieju Sep 8, 2025
eeccaac
update
bartlomieju Sep 8, 2025
37e0699
skip debug info
bartlomieju Sep 8, 2025
ced44aa
move doctests to next step
bartlomieju Sep 8, 2025
00be939
env vars for rustdoc
bartlomieju Sep 8, 2025
7ec87db
try to use codegen-units=1
bartlomieju Sep 8, 2025
e4a3da4
revert
bartlomieju Sep 8, 2025
01cdb50
add comments, revert windows XL
bartlomieju Sep 8, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .cargo/config.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
[target.'cfg(windows)']
rustflags = [
"-Csymbol-mangling-version=v0",
"-Ctarget-feature=+crt-static",
]
9 changes: 7 additions & 2 deletions .github/workflows/ci-job.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
save-if: ${{ inputs.is_main }}

- name: Clean
if: inputs.is_main
if: ${{ inputs.is_main || inputs.os == 'windows-2022-xl' }}
run: cargo clean

# ************************************************************************************************
Expand Down Expand Up @@ -132,4 +132,9 @@ jobs:
CARGO_INCREMENTAL: 0
GH_ACTIONS: 1
RUST_BACKTRACE: full
RUSTFLAGS: -D warnings
# note: this may be temporary
RUSTFLAGS: >-
-D warnings -Cdebuginfo=0 ${{ inputs.os == 'windows-2022-xl' &&
'-Clink-arg=/DEBUG:NONE' || '' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if its the increased disk space or this /DEBUG:None flg that fixed it. I guess we'll know when this is removed.

Also I noticed in your early attempt to disable debug info @bartlomieju that the option is not really passed all the way down to the linker. In this commit 310ff73, the final linker command still contains /DEBUG - not sure why.

CARGO_PROFILE_RELEASE_DEBUG: false
CARGO_BUILD_JOBS: 1
6 changes: 5 additions & 1 deletion .github/workflows/ci-test/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,16 @@ runs:
steps:
- name: Cargo test
shell: bash
env:
CARGO_PROFILE_RELEASE_DEBUG: false
run: |-
cargo nextest run --workspace --release --features "deno_core/default deno_core/include_js_files_for_snapshotting deno_core/unsafe_runtime_options deno_core/unsafe_use_unprotected_platform" --tests --examples --exclude deno_ops_compile_test_runner
cargo nextest run --workspace --release --features "deno_core/default deno_core/include_js_files_for_snapshotting deno_core/unsafe_runtime_options deno_core/unsafe_use_unprotected_platform" --tests --exclude deno_ops_compile_test_runner
cargo test --doc

- name: Run examples
shell: bash
env:
CARGO_PROFILE_RELEASE_DEBUG: false
# Only regression tests here for now.
# Regression test for https://github.com/denoland/deno/pull/19615.
run: |-
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
os: macOS-latest
jobs: [lint, test]
windows:
os: windows-2022
os: windows-2022-xl
jobs: [lint, test]
- name: Read job configuration (tag)
uses: cloudposse/github-action-yaml-config-query@main
Expand Down
Loading
Loading