-
Notifications
You must be signed in to change notification settings - Fork 130
feat: V8 14.0 #1187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: V8 14.0 #1187
Changes from 29 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
801042c
upgrade
devsnek f78c9bf
Merge branch 'main' into upgrade
bartlomieju 0f1eb76
some small progress
bartlomieju dcc7c19
bump v8
bartlomieju ce10b6b
fix
bartlomieju 67fa229
revert
bartlomieju f6879b3
actual fixes
bartlomieju 63b1a74
don't lint on Windows for the time being
bartlomieju dfbcb7e
turn off debug symbols
bartlomieju c1d78e8
Try again
bartlomieju 310ff73
again
bartlomieju 3f60a84
limit no of jobs
bartlomieju 6c2f1c8
reset CI
bartlomieju 0d27b74
always run cargo clean on windows
bartlomieju 99fa977
disable debug info altogether
bartlomieju 3defca6
Try to use windows-2025 image
bartlomieju 307cf5c
Try setting `/PDBPAGESIZE`
littledivy 4ec8429
-Csymbol-mangling-version=v0
littledivy 4b5108c
fmt
littledivy fbc786d
try to only test tests
bartlomieju f3dc0b2
try -Ctarget-feature=+crt-static
ry 180a31a
try /DEBUG:NONE
littledivy 48d6e02
x
littledivy 0a63853
try xl image
bartlomieju 5a1ea0b
x
littledivy fab6974
use 2022-xl
bartlomieju 8d9f90c
use 2022-xl 2
bartlomieju d875bd8
update expected output
bartlomieju 7f2e8f5
update expected output
bartlomieju 32cdfa9
revert changes
bartlomieju eeccaac
update
bartlomieju 37e0699
skip debug info
bartlomieju ced44aa
move doctests to next step
bartlomieju 00be939
env vars for rustdoc
bartlomieju 7ec87db
try to use codegen-units=1
bartlomieju e4a3da4
revert
bartlomieju 01cdb50
add comments, revert windows XL
bartlomieju File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
[target.'cfg(windows)'] | ||
rustflags = [ | ||
"-Csymbol-mangling-version=v0", | ||
"-Ctarget-feature=+crt-static", | ||
] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if its the increased disk space or this
/DEBUG:None
flg that fixed it. I guess we'll know when this is removed.Also I noticed in your early attempt to disable debug info @bartlomieju that the option is not really passed all the way down to the linker. In this commit 310ff73, the final linker command still contains
/DEBUG
- not sure why.