Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken screenshots on the README #4

Open
arunsathiya opened this issue Nov 5, 2023 · 0 comments · May be fixed by #5
Open

Broken screenshots on the README #4

arunsathiya opened this issue Nov 5, 2023 · 0 comments · May be fixed by #5

Comments

@arunsathiya
Copy link

arunsathiya commented Nov 5, 2023

All screenshots/images in the README are broken at the moment, example:

image

That's due to the underlying image paths being incorrect, example:

https://deno.com/build-a-blog-with-fresh/default-fresh-app.png

It must be:

https://deno.com/blog/build-a-blog-with-fresh/default-fresh-app.png

arunsathiya added a commit to arunsathiya/fresh-blog-example that referenced this issue Nov 5, 2023
Fixes denoland#4

It seems that the default fresh app screenshot on the README is broken at the moment because the underlying image is missing:

https://deno.com/build-a-blog-with-fresh/default-fresh-app.png

```
curl -LIX GET 'https://deno.com/build-a-blog-with-fresh/default-fresh-app.png' -H "Cache-Control: no-cache"
HTTP/2 404
content-type: text/html; charset=utf-8
cross-origin-embedder-policy: same-origin
cross-origin-opener-policy: same-origin
cross-origin-resource-policy: same-origin
referrer-policy: strict-origin-when-cross-origin
strict-transport-security: max-age=63072000; includeSubDomains; preload
x-content-type-options: nosniff
x-frame-options: DENY
vary: Accept-Encoding
date: Sun, 05 Nov 2023 17:53:47 GMT
via: http/2 edgeproxy-h
server: deno/gcp-us-west4
```

This PR replaces that screenshot path with a GitHub-hosted link.

If it's preferred that the screenshot remains hosted on Deno website (and fixed there), feel free to close this PR.
@arunsathiya arunsathiya linked a pull request Nov 5, 2023 that will close this issue
@arunsathiya arunsathiya changed the title Missing default fresh app screenshot Broken screenshots on the README Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant