Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shim Deno.Command #110

Open
dsherret opened this issue Jul 4, 2022 · 4 comments
Open

Shim Deno.Command #110

dsherret opened this issue Jul 4, 2022 · 4 comments
Labels
enhancement New feature or request help wanted

Comments

@dsherret
Copy link
Member

dsherret commented Jul 4, 2022

Once stabilized.
@dsherret dsherret added the enhancement New feature or request label Jul 4, 2022
@dsherret dsherret changed the title Shim Deno.spawn and spawnChild Shim Deno.Command Nov 23, 2022
@dsherret dsherret mentioned this issue Apr 7, 2023
Merged
@lilnasy
Copy link

lilnasy commented May 6, 2023

Do you have a general idea or pointers as to how this might be implemented?

@dsherret
Copy link
Member Author

dsherret commented May 8, 2023

I'm not sure. Maybe it would need to use node's web streams https://nodejs.org/api/webstreams.html

@dcdunkan dcdunkan mentioned this issue Jun 22, 2023
Merged
@scarf005 scarf005 mentioned this issue Jun 30, 2023
Closed
scarf005 added a commit to scarf005/deno-cliffy that referenced this issue Jun 30, 2023
@scarf005
build: publish to node
4d62b85 
blocked by denoland/node_shims#110
@disjukr disjukr mentioned this issue Dec 12, 2023
Merged
@mxcl
Copy link

mxcl commented Jan 29, 2024

This is the sort of thing I would step up to implement, but I don't feel confident I could do it right since I don't understand the full API.

Either way, considering the aggressive deprecation warnings in deno 1.40 for this API, time is now more pressing on implementing this.

@halvardssm
Copy link
Contributor

halvardssm commented Feb 27, 2024 •
edited
Loading

@dsherret Mind if I pick this one up? I would just do it by wrapping around node:child_proccess, unless there are reasons not to?

Edit:
I would probably align to what was implemented for Deno.run as it is very similar

@halvardssm halvardssm mentioned this issue Feb 28, 2024
Open
@felipecrs felipecrs mentioned this issue Mar 8, 2024
Merged
@barrysimpson barrysimpson mentioned this issue Nov 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mxcl @dsherret @halvardssm @lilnasy