Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Improve loading indicator animation loop and cleanup #622

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

oddballdave
Copy link
Collaborator

@oddballdave oddballdave commented Jan 14, 2025

Description of Change

Replaced repetitive animation firing in the LoadingIndicator with a loop and added a cleanup function.

Testing Packages

Screenshots/Video

Testing

Tested library on Android, iOS and Web. Also incorporated package into VA Mobile app and performed manual tests as well as detox/e2e tests.

  • Tested on iOS
  • Tested on Android
  • Tested on Web

PR Checklist

Code reviewer validation:

  • General
    • PR is linked to ticket(s)
    • PR has changelog label applied if it's to be included in the changelog
    • Acceptance criteria:
      • All satisfied or
      • Documented reason for not being performed or
      • Split to separate ticket and ticket is linked by relevant AC(s)
    • Above PR sections adequately filled out
    • If any breaking changes, in accordance with the pre-1.0.0 versioning guidelines: a CU ticket has been created for the VA Mobile App detailing necessary adjustments with the package version that will be published by this ticket
  • Code
    • Tests are included if appropriate (or split to separate ticket)
    • New functions have proper TSDoc annotations

Publish

If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:

@oddballdave oddballdave linked an issue Jan 14, 2025 that may be closed by this pull request
3 tasks
@oddballdave oddballdave added enhancement New feature or request changelog labels Jan 14, 2025
@oddballdave
Copy link
Collaborator Author

This PR will be ready for review when #621 is approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DS - Improve LoadingIndicator Animation Loop and Cleanup
2 participants