Add template_id, source_location, callback_metadata, and delivery status to callback logging (#20035)

Author: nathanbwright

modules/va_notify/app/controllers/va_notify/callbacks_controller.rb

@@ -17,8 +17,15 @@ def create
       notification_id = params[:id]
 
       if (notification = VANotify::Notification.find_by(notification_id: notification_id))
-        Rails.logger.info("va_notify callbacks - Updating notification #{notification.id}")
         notification.update(notification_params)
+        Rails.logger.info("va_notify callbacks - Updating notification: #{notification.id}",
+                          {
+                            source_location: notification.source_location,
+                            template_id: notification.template_id,
+                            callback_metadata: notification.callback_metadata,
+                            status: notification.status
+                          })
+
         VANotify::DefaultCallback.new(notification).call
         VANotify::StatusUpdate.new.delegate(notification_params.merge(id: notification_id))
       else

modules/va_notify/spec/requests/callbacks_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'rails_helper'
+require 'va_notify/default_callback'
 
 RSpec.describe 'VANotify Callbacks', type: :request do
   let(:valid_token) { Settings.vanotify.status_callback.bearer_token }
@@ -18,13 +19,26 @@
 
   describe 'POST #notifications' do
     it 'with found notification' do
-      notification = VANotify::Notification.create(notification_id: notification_id)
+      template_id = SecureRandom.uuid
+      notification = VANotify::Notification.create(notification_id: notification_id,
+                                                   source_location: 'some_location',
+                                                   callback_metadata: 'some_callback_metadata',
+                                                   template_id: template_id)
       expect(notification.status).to eq(nil)
+      allow(Rails.logger).to receive(:info)
+      callback_obj = double('VANotify::DefaultCallback')
+      allow(VANotify::DefaultCallback).to receive(:new).and_return(callback_obj)
+      allow(callback_obj).to receive(:call)
 
       post(callback_route,
            params: callback_params.to_json,
            headers: { 'Authorization' => "Bearer #{valid_token}", 'Content-Type' => 'application/json' })
 
+      expect(Rails.logger).to have_received(:info).with(
+        "va_notify callbacks - Updating notification: #{notification.id}",
+        { source_location: 'some_location', template_id: template_id, callback_metadata: 'some_callback_metadata',
+          status: 'delivered' }
+      )
       expect(response.body).to include('success')
       notification.reload
       expect(notification.status).to eq('delivered')