Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks like these dependencies are updatable in another way, so this is no longer needed. #10019

Open
1 task done
conan opened this issue Jun 17, 2024 · 0 comments
Open
1 task done
Labels
L: git:submodules Git submodules L: javascript T: bug 🐞 Something isn't working

Comments

@conan
Copy link

conan commented Jun 17, 2024

Is there an existing issue for this?

Package ecosystem

npm

Package manager version

No response

Language version

20.14.0

Manifest location and content before the Dependabot update

No response

dependabot.yml content

version: 2
updates:
  - package-ecosystem: "npm"
    directories:
      - "dir1"
      - "dir2"
      ... etc - currently 11 directories
    schedule:
      interval: "weekly"
    open-pull-requests-limit: 30
    groups:
      npm:
        patterns:
          - "*"
        update-types:
          - "patch"
          - "minor"     

Updated dependency

No response

What you expected to see, versus what you actually saw

This is the same as #439

Dependabot raised a group PR that updated a number of dependencies. This caused some of our tests to fail, so I pushed several commits to the same branch to fix those tests. The PR was reviewed by my colleague.

Expected:

I was expecting Dependabot to leave this PR alone, because I'd pushed to it.

Actual:

Dependabot subsequently closed the PR with the message:

Looks like these dependencies are updatable in another way, so this is no longer needed.

  • I now realise the docs state:

By default, Dependabot will stop rebasing a pull request once extra commits have been pushed to it.

This doesn't say that Dependabot won't close the PR and create a new one, but that it does feels like a bug - otherwise I'll always have to branch off from a Dependabot branch to add fixes, which is unintuitive. I don't expect PRs I'm actively developing to be closed by Dependabot.

Native package manager behavior

No response

Images of the diff or a link to the PR, issue, or logs

image

Smallest manifest that reproduces the issue

No response

@conan conan added the T: bug 🐞 Something isn't working label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: git:submodules Git submodules L: javascript T: bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant