Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version-2 directory has an unnecessary init check #137

Open
minorOffense opened this issue Sep 26, 2019 · 1 comment
Open

version-2 directory has an unnecessary init check #137

minorOffense opened this issue Sep 26, 2019 · 1 comment

Comments

@minorOffense
Copy link

https://github.com/deric/puppet-zookeeper/blob/master/manifests/config.pp#L81 Uses a flag to check if the data directory needs to be initialized. This is unnecessary because the "creates" flag on the exec will automatically know if it needs to run based on the presence of that file.

@deric
Copy link
Owner

deric commented Sep 27, 2019

I guess the motivation was that in some cases calling zookeeper-server-initialize might not be considered as dangerous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants