Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement - Keep default behavior when colcade or other JS fails #3

Open
kilianso opened this issue Jul 17, 2016 · 2 comments
Open

Comments

@kilianso
Copy link

kilianso commented Jul 17, 2016

Hey there, i really love your work with Masonry and Colcade! There's just one thing i want to mention here: If someone has a really slow internet connection or Colcade fails because of some JS errors, the correct grid appearance gets destroyed or appears way too late! You should consider, to keep the col class behavior (for example from bootstrap) and then just "fill the gaps" - I made this example with Masonry and it works just fine: http://codepen.io/kilianso/pen/EyvqYG

If you remove the JS, the grid still keeps it's columns, just with some gaps. But that is way better than full-width items across the page.

I don't need any transitions on resize or else, i just want to close the gaps with a left-to-right order, that's it and as you mentioned in the readme, Colcade would be more lightweight than masonry, so is there a way to achieve this?

@desandro
Copy link
Owner

Thank you for this suggestion. Yeah, I haven't thought enough about the no-JS fallback. My first thought was that the items are full width, with standard display block vertical stack, no grid. Your proposal could work as well.

Colcade is still pretty new, so I'd like to see how others approach this issue.

@klihelp
Copy link

klihelp commented Feb 4, 2017

any update on this?
eg: I use foundation block-grids columns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants