Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link assets by reference #21

Open
taesungh opened this issue Jan 16, 2023 · 1 comment
Open

Link assets by reference #21

taesungh opened this issue Jan 16, 2023 · 1 comment

Comments

@taesungh
Copy link
Member

Image assets are included in data files but specified only by file name. These images should be included as imports to ensure compile-time safety and open possibilities of improved asset caching. These changes may become irrelevant once switching to loading data and images from an external data source or CMS.
@taesungh taesungh mentioned this issue Jan 16, 2023
Closed
@taesungh
Copy link
Member Author

As discussed in #22, using require for dynamic data is okay, but there are still several images which reference the /public folder and do not have compile-time checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Link image assets by reference instead of by name designatuci/DUCI-website
1 participant
@taesungh