feat: upvote and retract votes for coauthors (vas3k#995)

* feature: upvote and retake vote works for coauthors

* refactor: upvote and retake vote inside Post methods

Author: dolshevsk

frontend/html/comments/types/battle.html

@@ -25,7 +25,7 @@
                             initial-is-voted
                             initial-upvote-timestamp="{{comment.upvoted_at}}"
                          {% endif %}
-                         {% if not me|can_upvote:comment or upvote_disabled %}is-disabled{% endif %}>
+                         {% if not me|can_upvote_comment:comment or upvote_disabled %}is-disabled{% endif %}>
         </comment-upvote>
 
         {% if comment.is_pinned %}

frontend/html/comments/types/bold.html

@@ -56,7 +56,7 @@
                             initial-is-voted
                             initial-upvote-timestamp="{{comment.upvoted_at}}"
                          {% endif %}
-                         {% if not me|can_upvote:comment or upvote_disabled %}is-disabled{% endif %}>
+                         {% if not me|can_upvote_comment:comment or upvote_disabled %}is-disabled{% endif %}>
         </comment-upvote>
 
         {% if comment.is_pinned %}

frontend/html/comments/types/normal.html

@@ -63,7 +63,7 @@
                             initial-is-voted
                             initial-upvote-timestamp="{{comment.upvoted_at}}"
                          {% endif %}
-                         {% if not me|can_upvote:comment or upvote_disabled %}is-disabled{% endif %}
+                         {% if not me|can_upvote_comment:comment or upvote_disabled %}is-disabled{% endif %}
                          is-small>
         </comment-upvote>
 

frontend/html/comments/types/reply.html

@@ -58,7 +58,7 @@
                                 initial-is-voted
                                 initial-upvote-timestamp="{{comment.upvoted_at}}"
                              {% endif %}
-                             {% if not me|can_upvote:comment or upvote_disabled %}is-disabled{% endif %}
+                             {% if not me|can_upvote_comment:comment or upvote_disabled %}is-disabled{% endif %}
                              is-inline>
             </comment-upvote>
         </div>

frontend/html/posts/items/battle.html

@@ -28,7 +28,7 @@
                         initial-is-voted
                         initial-upvote-timestamp={{post.upvoted_at}}
                      {% endif %}
-                     {% if not me|can_upvote:post or upvote_disabled %}is-disabled{% endif %}>
+                     {% if not me|can_upvote_post:post or upvote_disabled %}is-disabled{% endif %}>
         </post-upvote>
     </div>
     <div class="feed-post-footer">

frontend/html/posts/items/event.html

@@ -28,7 +28,7 @@
                         initial-is-voted
                         initial-upvote-timestamp={{post.upvoted_at}}
                      {% endif %}
-                     {% if not me|can_upvote:post or upvote_disabled %}is-disabled{% endif %}>
+                     {% if not me|can_upvote_post:post or upvote_disabled %}is-disabled{% endif %}>
         </post-upvote>
     </div>
 

frontend/html/posts/items/idea.html

@@ -29,7 +29,7 @@
                         initial-is-voted
                         initial-upvote-timestamp={{post.upvoted_at}}
                      {% endif %}
-                     {% if not me|can_upvote:post or upvote_disabled %}is-disabled{% endif %}>
+                     {% if not me|can_upvote_post:post or upvote_disabled %}is-disabled{% endif %}>
         </post-upvote>
     </div>
 

frontend/html/posts/items/intro.html

@@ -24,7 +24,7 @@
                             initial-is-voted
                             initial-upvote-timestamp={{post.upvoted_at}}
                          {% endif %}
-                         {% if not me|can_upvote:post or upvote_disabled %}is-disabled{% endif %}
+                         {% if not me|can_upvote_post:post or upvote_disabled %}is-disabled{% endif %}
                          is-inline>
             </post-upvote>
 

frontend/html/posts/items/link.html

@@ -27,7 +27,7 @@
                         initial-is-voted
                         initial-upvote-timestamp={{post.upvoted_at}}
                      {% endif %}
-                     {% if not me|can_upvote:post or upvote_disabled %}is-disabled{% endif %}>
+                     {% if not me|can_upvote_post:post or upvote_disabled %}is-disabled{% endif %}>
         </post-upvote>
     </div>
 

frontend/html/posts/items/post.html

@@ -27,7 +27,7 @@
                         initial-is-voted
                         initial-upvote-timestamp={{post.upvoted_at}}
                      {% endif %}
-                     {% if not me|can_upvote:post or upvote_disabled %}is-disabled{% endif %}>
+                     {% if not me|can_upvote_post:post or upvote_disabled %}is-disabled{% endif %}>
         </post-upvote>
     </div>
     <div class="feed-post-footer">

frontend/html/posts/items/project.html

@@ -31,7 +31,7 @@
                         initial-is-voted
                         initial-upvote-timestamp={{post.upvoted_at}}
                      {% endif %}
-                     {% if not me|can_upvote:post or upvote_disabled %}is-disabled{% endif %}>
+                     {% if not me|can_upvote_post:post or upvote_disabled %}is-disabled{% endif %}>
         </post-upvote>
     </div>
 

frontend/html/posts/items/question.html

@@ -29,7 +29,7 @@
                         initial-is-voted
                         initial-upvote-timestamp={{post.upvoted_at}}
                      {% endif %}
-                     {% if not me|can_upvote:post or upvote_disabled %}is-disabled{% endif %}>
+                     {% if not me|can_upvote_post:post or upvote_disabled %}is-disabled{% endif %}>
         </post-upvote>
     </div>
 

frontend/html/posts/show/battle.html

@@ -60,7 +60,7 @@
                                 initial-is-voted
                                 initial-upvote-timestamp={{upvoted_at}}
                              {% endif %}
-                             {% if not me|can_upvote:post or upvote_disabled %}is-disabled{% endif %}>
+                             {% if not me|can_upvote_post:post or upvote_disabled %}is-disabled{% endif %}>
                 </post-upvote>
                 <div class="clearfix20"></div>
             </div>

frontend/html/posts/show/intro.html

@@ -52,7 +52,7 @@ <h1 class="post-title">
                             initial-is-voted
                             initial-upvote-timestamp={{upvoted_at}}
                          {% endif %}
-                         {% if not me|can_upvote:post or upvote_disabled %}is-disabled{% endif %}>
+                         {% if not me|can_upvote_post:post or upvote_disabled %}is-disabled{% endif %}>
             </post-upvote>
             <div class="text-body text-body-type-post e-content">
                 {% render_post post %}

frontend/html/posts/show/post.html

@@ -86,7 +86,7 @@ <h1 class="post-title">
                                     initial-is-voted
                                     initial-upvote-timestamp={{upvoted_at}}
                                  {% endif %}
-                                 {% if not me|can_upvote:post or upvote_disabled %}is-disabled{% endif %}>
+                                 {% if not me|can_upvote_post:post or upvote_disabled %}is-disabled{% endif %}>
                     </post-upvote>
                 {% endblock %}
 

frontend/html/posts/show/question.html

@@ -16,7 +16,7 @@
                                 initial-is-voted
                                 initial-upvote-timestamp={{upvoted_at}}
                              {% endif %}
-                             {% if not me|can_upvote:post or upvote_disabled %}is-disabled{% endif %}>
+                             {% if not me|can_upvote_post:post or upvote_disabled %}is-disabled{% endif %}>
                 </post-upvote>
             </div>
         {% endblock %}

gdpr/forget.py

@@ -49,6 +49,15 @@ def delete_user_data(user: User):
     # delete draft and unpublished posts
     Post.objects.filter(author=user, is_visible=False).delete()
 
+    # remove user from coauthors
+    posts = Post.objects.filter(coauthors__contains=[old_slug])
+    for post in posts:
+        try:
+            post.coauthors.remove(old_slug)
+            post.save()
+        except ValueError:
+            pass
+
     # transfer visible post ownership to "@deleted" user
     deleted_user = User.objects.filter(slug=settings.DELETED_USERNAME).first()
     if deleted_user:

posts/forms/compose.py

@@ -89,15 +89,20 @@ def clean_topic(self):
         return topic
 
     def clean_coauthors(self):
-        coathors = self.cleaned_data.get("coauthors")
-        if not coathors:
+        coauthors = self.cleaned_data.get("coauthors")
+        if not coauthors:
             return []
 
-        non_existing_coauthors = [coauthor for coauthor in coathors if not User.objects.filter(slug=coauthor).exists()]
+        seen = set()
+        duplicated_coauthors = [coauthor for coauthor in coauthors if coauthor in seen or seen.add(coauthor)]
+        if duplicated_coauthors:
+            raise ValidationError("Пользователи уже соавторы: {}".format(', '.join(duplicated_coauthors)))
+
+        non_existing_coauthors = [coauthor for coauthor in coauthors if not User.objects.filter(slug=coauthor).exists()]
         if non_existing_coauthors:
             raise ValidationError("Несуществующие пользователи: {}".format(', '.join(non_existing_coauthors)))
 
-        return coathors
+        return coauthors
 
 
 class PostTextForm(PostForm):

posts/models/post.py

@@ -167,11 +167,21 @@ def increment_view_count(self):
         return Post.objects.filter(id=self.id).update(view_count=F("view_count") + 1)
 
     def increment_vote_count(self):
+        if self.coauthors:
+            self.increment_coauthors_vote_count()
         return Post.objects.filter(id=self.id).update(upvotes=F("upvotes") + 1)
 
     def decrement_vote_count(self):
+        if self.coauthors:
+            self.decrement_coauthors_vote_count()
         return Post.objects.filter(id=self.id).update(upvotes=F("upvotes") - 1)
 
+    def increment_coauthors_vote_count(self):
+        return User.objects.filter(slug__in=self.coauthors).update(upvotes=F("upvotes") + 1)
+
+    def decrement_coauthors_vote_count(self):
+        return User.objects.filter(slug__in=self.coauthors, upvotes__gt=0).update(upvotes=F("upvotes") - 1)
+
     def can_edit(self, user):
         return self.author == user or user.is_moderator or user.slug in self.coauthors
 

posts/models/votes.py

@@ -25,7 +25,7 @@ class Meta:
 
     @classmethod
     def upvote(cls, user, post, request=None):
-        if not user.is_god and user.id == post.author_id:
+        if not user.is_god and (user.id == post.author_id or user.slug in post.coauthors):
             return None, False
 
         post_vote, is_vote_created = PostVote.objects.get_or_create(
@@ -48,7 +48,7 @@ def is_retractable(self):
 
     @classmethod
     def retract_vote(cls, request, user, post):
-        if not user.is_god and user.id == post.author_id:
+        if not user.is_god and (user.id == post.author_id or user.slug in post.coauthors):
             return False
 
         try:

posts/templatetags/posts.py

@@ -100,8 +100,13 @@ def link_summary(post):
 
 
 @register.filter
-def can_upvote(user, post_or_comment):
-    return bool(user and user != post_or_comment.author)
+def can_upvote_post(user, post):
+    return bool(user and user != post.author and user.slug not in post.coauthors)
+
+
+@register.filter
+def can_upvote_comment(user, comment):
+    return bool(user and user != comment.author)
 
 
 @register.filter

posts/views/posts.py

@@ -128,7 +128,7 @@ def upvote_post(request, post_slug):
         "post": {
             "upvotes": post.upvotes + (1 if is_vote_created else 0),
         },
-        "upvoted_timestamp": int(post_vote.created_at.timestamp() * 1000)
+        "upvoted_timestamp": int(post_vote.created_at.timestamp() * 1000) if post_vote else 0
     }