Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Easy] Feature request: display revenue numbers in a human readable format #3

Open
DataDrivenEngineer opened this issue Apr 29, 2022 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@DataDrivenEngineer
Copy link
Contributor

Difficulty

Easy

What you need to do

Read description of the issue below and try to fix it.

Hints

  1. Read issue description below carefully and ensure that you understand it
  2. Run the app and ensure that you can reproduce the issue. 'Reproducing issue' means that when you run the app locally, you see the same behavior as described in the issue.
  3. Begin by exploring the code to understand which parts of code are responsible for displaying revenue numbers. Remember: the more thoroughly you understand the code, the more elegant and lightweight solution you will be able to come up with.

Issue description

'Revenue YTD' column displays numbers unformatted, which is very hard for humans to read - see the image below:

unformatted-numbers

Expected behavior

'Revenue YTD' column displays numbers formatted to separate thousands groups with a space.
For example, number 1234567890 should be displayed as 1 234 567 890

@DataDrivenEngineer DataDrivenEngineer added enhancement New feature or request good first issue Good for newcomers labels Apr 29, 2022
@Shiganshina
Copy link

Hi,
After cloning the repository on my laptop it's just showing a blank screen with only "My Customers" written on it. Could you please help regarding this...

oss11

@lakshay007
Copy link

Thank you for this project, being a beginner, it was a learning experience
Screenshot 2022-04-29 171839

@lakshay007
Copy link

you have to run the backend also, how else will it fetch data

@DataDrivenEngineer
Copy link
Contributor Author

DataDrivenEngineer commented Apr 29, 2022

@Shiganshina hi, basically what @lakshay007 said. You have to start backend first. Pls refer to readme, there are instructions on how to run the app locally.

Please also consider joining our discord to ask for help there if needed - the link is also in the readme to this repo.

japoodev added a commit to japoodev/vanilla-crm that referenced this issue Nov 18, 2022
Krishvora added a commit to Krishvora/vanilla-crm that referenced this issue Nov 24, 2022
JunYuHuang added a commit to JunYuHuang/javascript-crm that referenced this issue Apr 9, 2023
clowjs added a commit to clowjs/javascript-crm that referenced this issue Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants