From 71b009fa8ae52d08817290d209e9af044908747b Mon Sep 17 00:00:00 2001 From: Fabius Gasber Date: Fri, 5 Jan 2024 17:39:36 +0100 Subject: [PATCH 1/8] Fix nav buttons --- src/index.html | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/index.html b/src/index.html index 04bd19e..b5ad27f 100644 --- a/src/index.html +++ b/src/index.html @@ -20,12 +20,12 @@ id="hamburger-button" onclick="toggleNav()" title="Toggle Navigation Menu" - > + > + - - Browse Challenges - Sign Up + + Browse Challenges + Sign Up From b00efde7a9e9dd4dd5f045f333121152397ad456 Mon Sep 17 00:00:00 2001 From: Fabius Gasber Date: Fri, 5 Jan 2024 17:51:29 +0100 Subject: [PATCH 2/8] Fix Issue, Desktop Nav Is Visible on Mobile --- src/index.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/index.html b/src/index.html index b5ad27f..05b1eef 100644 --- a/src/index.html +++ b/src/index.html @@ -23,9 +23,9 @@ > - - Browse Challenges - Sign Up + + Browse Challenges + Sign Up From b54d4f374ca0ae860103e2b12f4e06551fe205a2 Mon Sep 17 00:00:00 2001 From: Fabius Gasber Date: Fri, 5 Jan 2024 17:53:24 +0100 Subject: [PATCH 3/8] Invert banner colors using CSS --- src/styles.css | 1 + 1 file changed, 1 insertion(+) diff --git a/src/styles.css b/src/styles.css index 2cbb72e..5c935b1 100644 --- a/src/styles.css +++ b/src/styles.css @@ -670,6 +670,7 @@ form > span { #jumbo-image { max-height: 20rem; /* TODO: Invert banner colors using CSS */ + filter: invert(1); } @media (max-width: 600px) { From 42f84816d3d7e579c64297d1b9a91c848fecc8f1 Mon Sep 17 00:00:00 2001 From: Fabius Gasber Date: Fri, 5 Jan 2024 17:54:54 +0100 Subject: [PATCH 4/8] Add 2x2 Grid --- src/styles.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/styles.css b/src/styles.css index 5c935b1..8873292 100644 --- a/src/styles.css +++ b/src/styles.css @@ -878,7 +878,7 @@ form > span { #challenge-grid { display: grid; /* TODO: Fix Issue, Tiles Need to be 2x2 Grid. Change only grid-template-columns */ - grid-template-columns: none; + grid-template-columns: 1fr 1fr; grid-auto-rows: 10rem; gap: 1rem; padding-top: 2rem; From 00d9c94a446af424b300f55bb669aa1545406cce Mon Sep 17 00:00:00 2001 From: Fabius Gasber Date: Fri, 5 Jan 2024 18:10:59 +0100 Subject: [PATCH 5/8] Show Correct Status Messages on Signup Form --- src/script.js | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/script.js b/src/script.js index 529f585..98a03dc 100644 --- a/src/script.js +++ b/src/script.js @@ -30,6 +30,15 @@ addEventListener("submit", (event) => { // 2. empty email // 3. taken email // 4. repeat email + email.length === 0 ? renderEmailEmptyError() : resetMessage(); + let user = usersTable.find((user) => user.username === email); + if(user){ + renderEmailTakenError(); + } + else{ + renderSuccess(); + usersTable.push({username: `${email}`}); + } }); let toggleNav = () => { From f66a04031cf50d81d0b3c822c9b8550e97b05b2f Mon Sep 17 00:00:00 2001 From: Fabius Gasber Date: Fri, 5 Jan 2024 18:14:41 +0100 Subject: [PATCH 6/8] Fix issue with logo nav --- src/index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/index.html b/src/index.html index 05b1eef..1fad64c 100644 --- a/src/index.html +++ b/src/index.html @@ -23,7 +23,7 @@ > - + Browse Challenges Sign Up From e258507f2152371c3cab2af919fe856565a14eb2 Mon Sep 17 00:00:00 2001 From: Fabius Gasber Date: Fri, 5 Jan 2024 18:17:49 +0100 Subject: [PATCH 7/8] Show Correct Status Messages on Signup Form --- src/script.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/script.js b/src/script.js index 98a03dc..a60ab52 100644 --- a/src/script.js +++ b/src/script.js @@ -30,15 +30,17 @@ addEventListener("submit", (event) => { // 2. empty email // 3. taken email // 4. repeat email - email.length === 0 ? renderEmailEmptyError() : resetMessage(); let user = usersTable.find((user) => user.username === email); if(user){ renderEmailTakenError(); } - else{ + else if(email.length !== 0){ renderSuccess(); usersTable.push({username: `${email}`}); } + else { + renderEmailEmptyError(); + } }); let toggleNav = () => { From 66a26ae86f6927f2b78b6cd33b3f68e4b215313c Mon Sep 17 00:00:00 2001 From: Fabius Gasber Date: Fri, 5 Jan 2024 18:21:24 +0100 Subject: [PATCH 8/8] Fix nav buttons on mobile --- src/index.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/index.html b/src/index.html index 1fad64c..eff3a69 100644 --- a/src/index.html +++ b/src/index.html @@ -30,8 +30,8 @@