chore: Bump (most) deps #1081
chore: Bump (most) deps #1081
Conversation
Co-authored-by: Jason Miller <[email protected]>
🦋 Changeset detectedLatest commit: 9d764e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +1.2 kB (+4.69%) 🔍 Total Size: 26.9 kB
|
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "moduleResolution": "node", | |||
There was a problem hiding this comment.
tslib otherwise can't be found, oddly. This should be the default but maybe rtp2 is doing something odd.
| - name: compressed-size-action | ||
| uses: preactjs/compressed-size-action@v2 | ||
| with: | ||
| pattern: 'test/fixtures/**/dist/!(*.map)' | ||
| build-script: 'test' | ||
| repo-token: '${{ secrets.GITHUB_TOKEN }}' |
There was a problem hiding this comment.
Test suite already covers this really, we don't need a separate readout for file size bumps in a PR comment.
Also this is not aligning w/ the 'Test' CI action, probably Node version differences that isn't worth trying to hack around
|
This is IMO very important to merge. I need to manualy override "rollup-plugin-typescript2" to latest (0.36.0) everywhere I use microbundle, else it can't compile typescript because it can't find the types: I had the solution found a year or so ago, but forgot about it and did get cought by it again and wasted a few hours to find out how to solve it. Workaround: Add this to your If you use npm workspaces make sure it is overwritten and not existing anymore in |
|
@developit If you have a few minutes, would appreciate a peek at this and potentially #1082 & #1083 -- we're starting to hit dep rot |
| @@ -2320,26 +2319,26 @@ modern-generators | |||
|
|
|||
|
|
|||
| Build \\"modern-generators\\" to dist: | |||
| 248 B: modern-generators.js.gz | |||
| 201 B: modern-generators.js.br | |||
| 2.57 kB: modern-generators.js.gz | |||
There was a problem hiding this comment.
Are we ok with this massive increase?
There was a problem hiding this comment.
Hey, long time no see! Hope all is well & good w/ you.
Mentioned this above in a resolved comment:
Oh nice,
7.18.0ended up inlining regenerator as a normal helper, dropping the global: babel/babel#14538This is a sizable increase but IMO it's completely reasonable.
I still think this is reasonable, but admittedly, I was very much not a fan of Babel's previous behavior.
Do you disagree with this? I suppose we could work around it and revert to previous behavior if we really needed to.
src/lib/babel-custom.js
Outdated
| @@ -7,6 +7,16 @@ const ESMODULES_TARGET = { | |||
| esmodules: true, | |||
| }; | |||
|
|
|||
| // silence Babel 7.13+ loose-with-assumptions warnings | |||
There was a problem hiding this comment.
why do we want to silence this?
There was a problem hiding this comment.
Great question, will look into it & improve the comment (or remove this entirely) as I don't quite remember myself.
There was a problem hiding this comment.
Thanks for the mention! Indeed, seems like a silly hack I inserted when testing and forgot to clean up/fix.
Supersedes #969