Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some actions (e.g. pixelizing) can't be undone #170

Open
mbernwieser opened this issue May 5, 2022 · 2 comments
Open

Some actions (e.g. pixelizing) can't be undone #170

mbernwieser opened this issue May 5, 2022 · 2 comments
Labels

Comments

@mbernwieser
Copy link

Describe the bug
Some actions can't be undone with the "undo"-button. At least for the following actions it does not work:

  • Pixelizing
  • Croping
  • Rotating

Painterro version
1.2.73

To Reproduce
Steps to reproduce the behavior:

  1. Open any image with painterro
  2. Pixelize an area in the image
  3. Try to undo the pixelize-action
  4. Can't be undone

Expected behavior
The undo-function should work for every action of the editor

Screenshots
image

Browser

  • Chrome v100 - MacBook Air (macOS 12.3.1)
  • Chrome v100 - Linux Mint 20
ivictbor added a commit that referenced this issue May 5, 2022
@ivictbor
Copy link
Collaborator

ivictbor commented May 5, 2022

@mbernwieser oh, thanks, fixed and published new release,

this is sideeffect of #149 , all tools mentioned are one-timers which always return to select so now it should be handled correctly. Though this undo/redo staff requires a lot of testing, please touch it and let me know whether I did not broke smth else

@mbernwieser
Copy link
Author

@ivictbor wow, thank you very much for the quick fix!

Works just fine!

I think I found two more actions which are not working:

  • any change you do in "settings"
  • clear-action with the trash-bin icon

image

@ivictbor ivictbor added the bug label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants