Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y]: Accept/Cancel buttons for Text tool do not have accessible names #194

Open
ozyx opened this issue Mar 6, 2024 · 1 comment
Open

Comments

@ozyx
Copy link

ozyx commented Mar 6, 2024

Describe the bug
The "Accept" and "Cancel" buttons when adding text do not have accessible names.
image

In the accessibility tree:
image
You'll notice that the elements have a title attribute, but no ARIA attributes.

Painterro version
1.2.87

To Reproduce
Steps to reproduce the behavior:

  1. On the painterro canvas, select the "Text" tool
  2. Click anywhere to enter text
  3. Notice the "Accept" and "Cancel" buttons appear under the text box
  4. Right-click, inspect, and notice there are no ARIA attributes in the accessibility tree

Expected behavior
The "Accept" and "Cancel" buttons for text entry should have accessible names.

Screenshots
See above

Browser
Chrome 122

@ivictbor
Copy link
Collaborator

ivictbor commented Mar 6, 2024

Oh wow, thabks, did not know about it, feel free to add pull request with this aria stuff for all buttons, I will merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants