feat: create page for pet register breed issue#93 #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alecell
suggested changes
Mar 19, 2024
diogocaronte
requested changes
Apr 3, 2024
|
seu arquivo .husky/prepare-commit-msg está com conflito com a main |
Alecell
suggested changes
Apr 5, 2024
Alecell
approved these changes
Apr 12, 2024
muritadb
force-pushed
the
issue-93
branch
2 times, most recently
from
ad25f93
to
f4c3c7f
Compare
Alecell
suggested changes
Apr 19, 2024
There was a problem hiding this comment.
Isso não pode acontecer em nenhuma resolução
O espaçamento entre o botão e o grid de cachorros está errado
O espaçamento entre os cards dos cachorros está errado
Aproveita e colocar cursor: pointer nos petcards
Outra coisa que acabamos esquecendo de colocar na sua task mas é crucial é que vc precisa fazer com que o container de raças seja escrollavel quando a quantidade de itens for maior que o espaço disponível
Alecell
suggested changes
May 6, 2024
Alecell
approved these changes
May 15, 2024
diogocaronte
approved these changes
May 15, 2024
add other component for test rendering Fix: rename files dog images and add petcard into page feat: create page for select dog breed fix: cleaning hard coded of index.js fix: cleaning hard coded of index.js fix: fix import locale initializeScrollable component fix: fixed style PetRegisterPage property unnecessary feat: active button only breed is selected docs: create events for component petRegisterPage docs: create events for component petRegisterPage feat: active button when select pet card docs: create methods for petregisterPage docs: create methods for petregisterPage fix: fix methods at petRegisterPage fix: fix methods at petRegisterPage feat: listen submit pet card event docs: Comment changes for my component work in hard coded refactor: refactor name methods Activate and deactivate, of PetCard component refactor: normalize locale create of const events for components refactor: refactor name methods in PEtCard component docs: create petcard storie for documentation fix: fix the EOF PetCard/index.scss file refactor: change conditional on checks if card is active docs: Set documentation for PetRegisterPage docs: Set documentation for mock data in Readme refactor: cleaning home for re-review
Alecell
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #93
Feature
Pagina de cadastro de pets com opção de seleção, utilizando os componentes Petcard e Button
Changelog
CRIAÇÃO DO COMPONENTE
Foi criado o componente PetRegisterPage em home/components, nele utiliza components de src/components(Button e PetCard) para composição da pagina.
Para renderiza-lo em tela tive que importar na home/index.js e comentando o component NoPetRegirestedPage para não sobrepor e/ou aumentar o container(pra não ter rolagem de tela) simulando um redirect para a pagina de cadastro.
ESTILO DA PAGINA
Aqui no index.scss tive que adaptar as classes '__button ' e '__pet-card':
FAKE DATA
Inicialmente tive dificuldades em renderizar mais de um pet-card, fui informado que seriam "buscados" do backend por meio de requisições, então utilizando de um array de objetos com os pets, consegui o layout desejado.
Visual evidences 🖼️
Checklist
Additional info
Talvez será informado nas replies mas preciso de ajuda na responsividade, não consegui ajustar o layout para mobile.