Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contunuação do PR = feat: Add RadioButton e Checkbox #121

Merged
merged 6 commits into from
Apr 9, 2024
Merged

Contunuação do PR = feat: Add RadioButton e Checkbox #121

merged 6 commits into from
Apr 9, 2024

Conversation

PiluVitu
Copy link
Member

@PiluVitu PiluVitu commented Mar 28, 2024 •
edited
Loading

Continuação do pr aberto pela @jeressy #90

O novo pr foi aberto devido a não possibilidade de commit na main do fork da @jeressy, impossibilitando assim a continuação da task

Closes #25

Feature Adiciona os componentes RadioButton e Checkbox.
Visual evidences 🖼️
  • Checkbox:

Checkbox

  • Radio Button:

radio_btn

  • Componentes no storybook
Gravando.2024-04-04.202656.mp4
Additional info Ambos componentes foram documentados no storybook; Checkbox possui suporte para ter opções desativadas, conforme na imagem acima.

jeressy and others added 2 commits March 28, 2024 02:59
@jeressy @PiluVitu
feat: Componentes Radio Button e Checkbox
326eb8e 
Adiciona os componentes de radio button e checkbox, além de seus respectivos arquivos do storybook

refactor: Ajustes de evento, stories e getters/setters

fix: resolve parcial conversations

fix: resolve most part of conversations
@PiluVitu
fix: all conflicts erros
c846924
@PiluVitu PiluVitu self-assigned this Mar 28, 2024
@PiluVitu
Copy link
Member Author

@jeressy

@PiluVitu PiluVitu changed the title Issue 25 Contunuação do PR = feat: Add RadioButton e Checkbox Mar 28, 2024
diogocaronte
diogocaronte requested changes Mar 28, 2024
View reviewed changes
src/components/AvatarButton/index.scss Outdated Show resolved Hide resolved
src/components/Checkbox/index.js Outdated Show resolved Hide resolved
src/components/Checkbox/index.js Outdated Show resolved Hide resolved
src/components/Checkbox/index.js Show resolved Hide resolved
src/components/Checkbox/index.js Show resolved Hide resolved
src/components/RadioButton/index.js Outdated Show resolved Hide resolved
src/components/RadioButton/index.js Outdated Show resolved Hide resolved
src/stories/RadioButton.stories.js Show resolved Hide resolved
src/components/RadioButton/index.js Outdated Show resolved Hide resolved
src/components/RadioButton/index.js Outdated Show resolved Hide resolved
Alecell
Alecell reviewed Apr 5, 2024
View reviewed changes
Copy link
Contributor

@Alecell Alecell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parece que esse PR tem muito mais arquivos doque realmente deveria ter. Verificar isso

src/components/AvatarButton/index.scss Outdated Show resolved Hide resolved
src/components/AvatarButton/index.scss Outdated Show resolved Hide resolved
src/home/index.html Outdated Show resolved Hide resolved
src/styles/colors.scss Outdated Show resolved Hide resolved
src/styles/fonts.scss Outdated Show resolved Hide resolved
src/components/Checkbox/index.scss Outdated Show resolved Hide resolved
src/components/Checkbox/index.scss Outdated Show resolved Hide resolved
src/components/Checkbox/index.scss Show resolved Hide resolved
src/components/RadioButton/index.js Show resolved Hide resolved
src/components/RadioButton/index.scss Outdated Show resolved Hide resolved
@PiluVitu PiluVitu requested a review from Alecell April 6, 2024 00:35
zoldyzdk
zoldyzdk requested changes Apr 9, 2024
View reviewed changes
Copy link
Member

@zoldyzdk zoldyzdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nos dois componentes o mouse fica pointer apenas na bolinha ou quadrado do check e radio, seria interessante que ele ficasse no botão todo.

@zoldyzdk zoldyzdk merged commit b5558c8 into main Apr 9, 2024
@zoldyzdk zoldyzdk deleted the issue-25 branch April 9, 2024 21:25
juliaam pushed a commit to juliaam/pet-dex-frontend that referenced this pull request Apr 12, 2024
@PiluVitu @juliaam
Contunuação do PR = feat: Add RadioButton e Checkbox (devhatt#121)
bd9f104 
* feat: Componentes Radio Button e Checkbox

Adiciona os componentes de radio button e checkbox, além de seus respectivos arquivos do storybook

refactor: Ajustes de evento, stories e getters/setters

fix: resolve parcial conversations

fix: resolve most part of conversations

* fix: all conflicts erros

* fix: resolve conversations issues

* fix: resolve conversations

* fix: resolve all conversations issues

* style: resolve zoldicas callout

---------

Co-authored-by: Jessica Rodrigues <[email protected]>, Paulo Vitu <[email protected]>
juliaam pushed a commit to juliaam/pet-dex-frontend that referenced this pull request Apr 19, 2024
@PiluVitu @juliaam
Contunuação do PR = feat: Add RadioButton e Checkbox (devhatt#121)
3ce1006 
* feat: Componentes Radio Button e Checkbox

Adiciona os componentes de radio button e checkbox, além de seus respectivos arquivos do storybook

refactor: Ajustes de evento, stories e getters/setters

fix: resolve parcial conversations

fix: resolve most part of conversations

* fix: all conflicts erros

* fix: resolve conversations issues

* fix: resolve conversations

* fix: resolve all conversations issues

* style: resolve zoldicas callout

---------

Co-authored-by: Jessica Rodrigues <[email protected]>, Paulo Vitu <[email protected]>
juliaam pushed a commit to juliaam/pet-dex-frontend that referenced this pull request Apr 26, 2024
@PiluVitu @juliaam
Contunuação do PR = feat: Add RadioButton e Checkbox (devhatt#121)
49f2be5 
* feat: Componentes Radio Button e Checkbox

Adiciona os componentes de radio button e checkbox, além de seus respectivos arquivos do storybook

refactor: Ajustes de evento, stories e getters/setters

fix: resolve parcial conversations

fix: resolve most part of conversations

* fix: all conflicts erros

* fix: resolve conversations issues

* fix: resolve conversations

* fix: resolve all conversations issues

* style: resolve zoldicas callout

---------

Co-authored-by: Jessica Rodrigues <[email protected]>, Paulo Vitu <[email protected]>
juliaam pushed a commit to juliaam/pet-dex-frontend that referenced this pull request Apr 26, 2024
@PiluVitu @juliaam
Contunuação do PR = feat: Add RadioButton e Checkbox (devhatt#121)
e7c6835 
* feat: Componentes Radio Button e Checkbox

Adiciona os componentes de radio button e checkbox, além de seus respectivos arquivos do storybook

refactor: Ajustes de evento, stories e getters/setters

fix: resolve parcial conversations

fix: resolve most part of conversations

* fix: all conflicts erros

* fix: resolve conversations issues

* fix: resolve conversations

* fix: resolve all conversations issues

* style: resolve zoldicas callout

---------

Co-authored-by: Jessica Rodrigues <[email protected]>, Paulo Vitu <[email protected]>
juliaam pushed a commit to juliaam/pet-dex-frontend that referenced this pull request May 8, 2024
@PiluVitu @juliaam
Contunuação do PR = feat: Add RadioButton e Checkbox (devhatt#121)
eee11f3 
* feat: Componentes Radio Button e Checkbox

Adiciona os componentes de radio button e checkbox, além de seus respectivos arquivos do storybook

refactor: Ajustes de evento, stories e getters/setters

fix: resolve parcial conversations

fix: resolve most part of conversations

* fix: all conflicts erros

* fix: resolve conversations issues

* fix: resolve conversations

* fix: resolve all conversations issues

* style: resolve zoldicas callout

---------

Co-authored-by: Jessica Rodrigues <[email protected]>, Paulo Vitu <[email protected]>
Alecell pushed a commit that referenced this pull request May 8, 2024
@juliaam @PiluVitu
Issue 109 - Componente de vacina (#125)
0b72433 
* feat: base component of vaccine

* feat: vaccine list

* fix: remove espace index home

* fix: right index home

* feat: storybook and div fix

* fix: pr changes - early return, border rem to px and format date function

* fix: pr changes

* feat: font helvetica

* feat: component abstraction

* fix: add borders and scroll

* Contunuação do PR = feat: Add RadioButton e Checkbox (#121)

* feat: Componentes Radio Button e Checkbox

Adiciona os componentes de radio button e checkbox, além de seus respectivos arquivos do storybook

refactor: Ajustes de evento, stories e getters/setters

fix: resolve parcial conversations

fix: resolve most part of conversations

* fix: all conflicts erros

* fix: resolve conversations issues

* fix: resolve conversations

* fix: resolve all conversations issues

* style: resolve zoldicas callout

---------

Co-authored-by: Jessica Rodrigues <[email protected]>, Paulo Vitu <[email protected]>

* fix: componente visual

* fix: scroll

* fix: pr improvements

* fix: update pnpm lock

* fix: color name

* fix: index html

* fix: stylelint font

* fix: pr changes

* fix: fonts and addvacine container name

* fix: vaccineitem corrrect events name  and id

* fix: vaccinegroup indentation

* fix: dividerr

* fix: code-style

* fix:stylelint

* fix: nomenclaturet improvements

* fix: stylelint

* fix: return textcontent

* feat: pnpm lock

---------

Co-authored-by: Paulo Victor <[email protected]>
DominMFD pushed a commit to DominMFD/pet-dex-frontend that referenced this pull request May 8, 2024
@juliaam @PiluVitu @DominMFD
Issue 109 - Componente de vacina (devhatt#125)
cc4d59a 
* feat: base component of vaccine

* feat: vaccine list

* fix: remove espace index home

* fix: right index home

* feat: storybook and div fix

* fix: pr changes - early return, border rem to px and format date function

* fix: pr changes

* feat: font helvetica

* feat: component abstraction

* fix: add borders and scroll

* Contunuação do PR = feat: Add RadioButton e Checkbox (devhatt#121)

* feat: Componentes Radio Button e Checkbox

Adiciona os componentes de radio button e checkbox, além de seus respectivos arquivos do storybook

refactor: Ajustes de evento, stories e getters/setters

fix: resolve parcial conversations

fix: resolve most part of conversations

* fix: all conflicts erros

* fix: resolve conversations issues

* fix: resolve conversations

* fix: resolve all conversations issues

* style: resolve zoldicas callout

---------

Co-authored-by: Jessica Rodrigues <[email protected]>, Paulo Vitu <[email protected]>

* fix: componente visual

* fix: scroll

* fix: pr improvements

* fix: update pnpm lock

* fix: color name

* fix: index html

* fix: stylelint font

* fix: pr changes

* fix: fonts and addvacine container name

* fix: vaccineitem corrrect events name  and id

* fix: vaccinegroup indentation

* fix: dividerr

* fix: code-style

* fix:stylelint

* fix: nomenclaturet improvements

* fix: stylelint

* fix: return textcontent

* feat: pnpm lock

---------

Co-authored-by: Paulo Victor <[email protected]>
RafaelLimaC pushed a commit to RafaelLimaC/pet-dex-frontend that referenced this pull request May 9, 2024
@juliaam @PiluVitu @RafaelLimaC
Issue 109 - Componente de vacina (devhatt#125)
73f7339 
* feat: base component of vaccine

* feat: vaccine list

* fix: remove espace index home

* fix: right index home

* feat: storybook and div fix

* fix: pr changes - early return, border rem to px and format date function

* fix: pr changes

* feat: font helvetica

* feat: component abstraction

* fix: add borders and scroll

* Contunuação do PR = feat: Add RadioButton e Checkbox (devhatt#121)

* feat: Componentes Radio Button e Checkbox

Adiciona os componentes de radio button e checkbox, além de seus respectivos arquivos do storybook

refactor: Ajustes de evento, stories e getters/setters

fix: resolve parcial conversations

fix: resolve most part of conversations

* fix: all conflicts erros

* fix: resolve conversations issues

* fix: resolve conversations

* fix: resolve all conversations issues

* style: resolve zoldicas callout

---------

Co-authored-by: Jessica Rodrigues <[email protected]>, Paulo Vitu <[email protected]>

* fix: componente visual

* fix: scroll

* fix: pr improvements

* fix: update pnpm lock

* fix: color name

* fix: index html

* fix: stylelint font

* fix: pr changes

* fix: fonts and addvacine container name

* fix: vaccineitem corrrect events name  and id

* fix: vaccinegroup indentation

* fix: dividerr

* fix: code-style

* fix:stylelint

* fix: nomenclaturet improvements

* fix: stylelint

* fix: return textcontent

* feat: pnpm lock

---------

Co-authored-by: Paulo Victor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diogocaronte diogocaronte diogocaronte approved these changes

@zoldyzdk zoldyzdk zoldyzdk approved these changes

@Alecell Alecell Awaiting requested review from Alecell

Assignees

@PiluVitu PiluVitu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Desenvolvimento de Componentes de Input Radio e Checkbox com Estados Dinâmicos
5 participants
@PiluVitu @Alecell @diogocaronte @zoldyzdk @jeressy