-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 109 - Componente de vacina #125
Conversation
O layout não está parecido com o do figma, consegue arrumar? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aparentemente seu resultado não está de acordo com o layout! Da uma revisada nisso e precisa atualizar a branch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Porque há alterações nos arquivos de Checkbox e Radio? Eles estão constando como arquivos completamente novos, precisa ajustar isso, talvez algum problema no git isso.
15b64a8
to
573657a
Compare
.github/workflows/code-style.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opa isso aqui ta certo? Acho que vc ta apagando o pipeline do @PiluVitu aqui!
tenta atualizar a branch
src/styles/fonts.scss
Outdated
@font-face { | ||
font-family: 'Helvetica'; | ||
font-weight: normal; | ||
font-style: normal; | ||
src: | ||
local('Helvetica'), | ||
url('/helvetica.woff') format('woff'); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
O font face precisa ta definidor no default css importado no root do projeto, caso contrario pode dar um ruinzinho
src/components/VaccineItem/index.js
Outdated
@@ -39,32 +44,29 @@ VaccineItem.prototype = Object.assign( | |||
return this.id; | |||
}, | |||
getTitle() { | |||
return this.title; | |||
return this.selected.get('title'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return this.selected.get('title'); | |
return this.selected.get('title').textContent; |
src/components/VaccineItem/index.js
Outdated
getVet() { | ||
return this.vet; | ||
getVeterinary() { | ||
return this.selected.get('veterinary'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return this.selected.get('veterinary'); | |
return this.selected.get('veterinary').textContent; |
src/components/VaccineItem/index.js
Outdated
}, | ||
getDate() { | ||
return this.date; | ||
return this.selected.get('date'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return this.selected.get('date'); | |
return this.selected.get('date').textContent; |
src/components/VaccineGroup/index.js
Outdated
} | ||
|
||
VaccineGroup.prototype = Object.assign( | ||
VaccineGroup.prototype, | ||
Component.prototype, | ||
{ | ||
getTitle() { | ||
return this.title; | ||
return this.selected.get('title'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return this.selected.get('title'); | |
return this.selected.get('title').textContent; |
* feat: Componentes Radio Button e Checkbox Adiciona os componentes de radio button e checkbox, além de seus respectivos arquivos do storybook refactor: Ajustes de evento, stories e getters/setters fix: resolve parcial conversations fix: resolve most part of conversations * fix: all conflicts erros * fix: resolve conversations issues * fix: resolve conversations * fix: resolve all conversations issues * style: resolve zoldicas callout --------- Co-authored-by: Jessica Rodrigues <[email protected]>, Paulo Vitu <[email protected]>
* feat: base component of vaccine * feat: vaccine list * fix: remove espace index home * fix: right index home * feat: storybook and div fix * fix: pr changes - early return, border rem to px and format date function * fix: pr changes * feat: font helvetica * feat: component abstraction * fix: add borders and scroll * Contunuação do PR = feat: Add RadioButton e Checkbox (devhatt#121) * feat: Componentes Radio Button e Checkbox Adiciona os componentes de radio button e checkbox, além de seus respectivos arquivos do storybook refactor: Ajustes de evento, stories e getters/setters fix: resolve parcial conversations fix: resolve most part of conversations * fix: all conflicts erros * fix: resolve conversations issues * fix: resolve conversations * fix: resolve all conversations issues * style: resolve zoldicas callout --------- Co-authored-by: Jessica Rodrigues <[email protected]>, Paulo Vitu <[email protected]> * fix: componente visual * fix: scroll * fix: pr improvements * fix: update pnpm lock * fix: color name * fix: index html * fix: stylelint font * fix: pr changes * fix: fonts and addvacine container name * fix: vaccineitem corrrect events name and id * fix: vaccinegroup indentation * fix: dividerr * fix: code-style * fix:stylelint * fix: nomenclaturet improvements * fix: stylelint * fix: return textcontent * feat: pnpm lock --------- Co-authored-by: Paulo Victor <[email protected]>
* feat: base component of vaccine * feat: vaccine list * fix: remove espace index home * fix: right index home * feat: storybook and div fix * fix: pr changes - early return, border rem to px and format date function * fix: pr changes * feat: font helvetica * feat: component abstraction * fix: add borders and scroll * Contunuação do PR = feat: Add RadioButton e Checkbox (devhatt#121) * feat: Componentes Radio Button e Checkbox Adiciona os componentes de radio button e checkbox, além de seus respectivos arquivos do storybook refactor: Ajustes de evento, stories e getters/setters fix: resolve parcial conversations fix: resolve most part of conversations * fix: all conflicts erros * fix: resolve conversations issues * fix: resolve conversations * fix: resolve all conversations issues * style: resolve zoldicas callout --------- Co-authored-by: Jessica Rodrigues <[email protected]>, Paulo Vitu <[email protected]> * fix: componente visual * fix: scroll * fix: pr improvements * fix: update pnpm lock * fix: color name * fix: index html * fix: stylelint font * fix: pr changes * fix: fonts and addvacine container name * fix: vaccineitem corrrect events name and id * fix: vaccinegroup indentation * fix: dividerr * fix: code-style * fix:stylelint * fix: nomenclaturet improvements * fix: stylelint * fix: return textcontent * feat: pnpm lock --------- Co-authored-by: Paulo Victor <[email protected]>
Closes #109
Feature
Adiciona o componente de vacina
Visual evidences 🖼️
Checklist