Issue 109 - Componente de vacina #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hxsggsz
requested changes
Apr 8, 2024
hxsggsz
approved these changes
Apr 8, 2024
diogocaronte
requested changes
Apr 8, 2024
|
O layout não está parecido com o do figma, consegue arrumar? |
PiluVitu
requested changes
Apr 9, 2024
Alecell
suggested changes
Apr 12, 2024
hxsggsz
approved these changes
Apr 17, 2024
diogocaronte
requested changes
Apr 18, 2024
Alecell
suggested changes
Apr 19, 2024
juliaam
force-pushed
the
issue-109
branch
3 times, most recently
from
15b64a8
to
573657a
Compare
aalmeida00
approved these changes
Apr 26, 2024
PiluVitu
approved these changes
Apr 26, 2024
Alecell
suggested changes
Apr 30, 2024
.github/workflows/code-style.yml
Outdated
There was a problem hiding this comment.
Opa isso aqui ta certo? Acho que vc ta apagando o pipeline do @PiluVitu aqui!
tenta atualizar a branch
src/styles/fonts.scss
Outdated
Comment on lines
80
to
87
| @font-face { | ||
| font-family: 'Helvetica'; | ||
| font-weight: normal; | ||
| font-style: normal; | ||
| src: | ||
| local('Helvetica'), | ||
| url('/helvetica.woff') format('woff'); | ||
| } |
There was a problem hiding this comment.
O font face precisa ta definidor no default css importado no root do projeto, caso contrario pode dar um ruinzinho
Alecell
suggested changes
May 7, 2024
Alecell
approved these changes
May 7, 2024
diogocaronte
approved these changes
May 7, 2024
diogocaronte
requested changes
May 7, 2024
src/components/VaccineItem/index.js
Outdated
| @@ -39,32 +44,29 @@ VaccineItem.prototype = Object.assign( | |||
| return this.id; | |||
| }, | |||
| getTitle() { | |||
| return this.title; | |||
| return this.selected.get('title'); | |||
There was a problem hiding this comment.
Suggested change
| return this.selected.get('title'); | |
| return this.selected.get('title').textContent; |
src/components/VaccineItem/index.js
Outdated
| getVet() { | ||
| return this.vet; | ||
| getVeterinary() { | ||
| return this.selected.get('veterinary'); |
There was a problem hiding this comment.
Suggested change
| return this.selected.get('veterinary'); | |
| return this.selected.get('veterinary').textContent; |
src/components/VaccineItem/index.js
Outdated
| }, | ||
| getDate() { | ||
| return this.date; | ||
| return this.selected.get('date'); |
There was a problem hiding this comment.
Suggested change
| return this.selected.get('date'); | |
| return this.selected.get('date').textContent; |
src/components/VaccineGroup/index.js
Outdated
| } | ||
|
|
||
| VaccineGroup.prototype = Object.assign( | ||
| VaccineGroup.prototype, | ||
| Component.prototype, | ||
| { | ||
| getTitle() { | ||
| return this.title; | ||
| return this.selected.get('title'); |
There was a problem hiding this comment.
Suggested change
| return this.selected.get('title'); | |
| return this.selected.get('title').textContent; |
diogocaronte
approved these changes
May 7, 2024
Alecell
approved these changes
May 8, 2024
* feat: Componentes Radio Button e Checkbox Adiciona os componentes de radio button e checkbox, além de seus respectivos arquivos do storybook refactor: Ajustes de evento, stories e getters/setters fix: resolve parcial conversations fix: resolve most part of conversations * fix: all conflicts erros * fix: resolve conversations issues * fix: resolve conversations * fix: resolve all conversations issues * style: resolve zoldicas callout --------- Co-authored-by: Jessica Rodrigues <[email protected]>, Paulo Vitu <[email protected]>
Alecell
approved these changes
May 8, 2024
DominMFD
pushed a commit
to DominMFD/pet-dex-frontend
that referenced
this pull request
May 8, 2024
* feat: base component of vaccine * feat: vaccine list * fix: remove espace index home * fix: right index home * feat: storybook and div fix * fix: pr changes - early return, border rem to px and format date function * fix: pr changes * feat: font helvetica * feat: component abstraction * fix: add borders and scroll * Contunuação do PR = feat: Add RadioButton e Checkbox (devhatt#121) * feat: Componentes Radio Button e Checkbox Adiciona os componentes de radio button e checkbox, além de seus respectivos arquivos do storybook refactor: Ajustes de evento, stories e getters/setters fix: resolve parcial conversations fix: resolve most part of conversations * fix: all conflicts erros * fix: resolve conversations issues * fix: resolve conversations * fix: resolve all conversations issues * style: resolve zoldicas callout --------- Co-authored-by: Jessica Rodrigues <[email protected]>, Paulo Vitu <[email protected]> * fix: componente visual * fix: scroll * fix: pr improvements * fix: update pnpm lock * fix: color name * fix: index html * fix: stylelint font * fix: pr changes * fix: fonts and addvacine container name * fix: vaccineitem corrrect events name and id * fix: vaccinegroup indentation * fix: dividerr * fix: code-style * fix:stylelint * fix: nomenclaturet improvements * fix: stylelint * fix: return textcontent * feat: pnpm lock --------- Co-authored-by: Paulo Victor <[email protected]>
RafaelLimaC
pushed a commit
to RafaelLimaC/pet-dex-frontend
that referenced
this pull request
May 9, 2024
* feat: base component of vaccine * feat: vaccine list * fix: remove espace index home * fix: right index home * feat: storybook and div fix * fix: pr changes - early return, border rem to px and format date function * fix: pr changes * feat: font helvetica * feat: component abstraction * fix: add borders and scroll * Contunuação do PR = feat: Add RadioButton e Checkbox (devhatt#121) * feat: Componentes Radio Button e Checkbox Adiciona os componentes de radio button e checkbox, além de seus respectivos arquivos do storybook refactor: Ajustes de evento, stories e getters/setters fix: resolve parcial conversations fix: resolve most part of conversations * fix: all conflicts erros * fix: resolve conversations issues * fix: resolve conversations * fix: resolve all conversations issues * style: resolve zoldicas callout --------- Co-authored-by: Jessica Rodrigues <[email protected]>, Paulo Vitu <[email protected]> * fix: componente visual * fix: scroll * fix: pr improvements * fix: update pnpm lock * fix: color name * fix: index html * fix: stylelint font * fix: pr changes * fix: fonts and addvacine container name * fix: vaccineitem corrrect events name and id * fix: vaccinegroup indentation * fix: dividerr * fix: code-style * fix:stylelint * fix: nomenclaturet improvements * fix: stylelint * fix: return textcontent * feat: pnpm lock --------- Co-authored-by: Paulo Victor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #109
Feature
Adiciona o componente de vacina
Visual evidences 🖼️
Checklist