feat(more-info): adding question card and optional observation input #43

geisabitt · 2024-01-05T21:54:07Z

Closes

Feature

Adicionar a pagina Conte-me mais sobre seu pet

Bugfix

Description
N/A
Cause
N/A
Solution
N/A

Changelog

N/A

Visual evidences 🖼️

Checklist

Issue linked
Build working correctly
Tests created

Additional info

Acredito que esteja complexo de mais e também não sei se está correto as nomenclaturas. estou renderizado as imformações apartir de um json, mas a lógica não está funcionando muito bem porque o card vacina está exibindo elementos dos outros cards

aalmeida00

Percebi que tem um arquivo html/css aqui, deveria?

questoes.json

src/assets/shield.svg

src/components/card-pet/index.css

src/components/card-pet/index.html

Alecell · 2024-01-08T01:22:48Z

O "Closes" deve seguir o ID da sua task, tipo " Closes #43 "

src/assets/dogs/Beagle.png

src/assets/shield.svg

src/components/card-pet/index.css

src/components/card-pet/index.html

src/components/card-pet/index.scss

src/home/index.html

src/components/card-pet/index.js

src/styles/base.scss

aalmeida00 · 2024-01-09T21:58:45Z

Alguma atualização aqui? @geisabitt

Voce precisa ajustar os conflitos da sua branch.

Aqui será necessário um rebase com o repositório remoto da devhatt, se precisar de ajuda me pinga no discord.

src/components/more-info/index.js

src/components/more-info/index.scss

src/home/main.js

geisabitt

Avaliar se os icones ficarão assim mesmo

src/components/card-pet/index.js

geisabitt · 2024-01-12T04:48:39Z

geisabitt · 2024-01-12T19:20:42Z

/approve

* add initial architecture example * fix node_modules in src * new structure example * refactor components * refactor: remove unused dependency * style: run prettier to fix EOF * add more tests

* docs: created readme.md file fix devhatt#5 * style: created readme.md file fix devhatt#5 * docs: created readme.md file with first steps fix devhatt#5

BREAKING CHANGE: Reinstall all dependencies

) Bumps the all-minor-updates group with 5 updates: | Package | From | To | | --- | --- | --- | | [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) | `5.0.3` | `5.0.10` | | [eslint](https://github.com/eslint/eslint) | `8.54.0` | `8.56.0` | | [lint-staged](https://github.com/okonet/lint-staged) | `15.1.0` | `15.2.0` | | [prettier](https://github.com/prettier/prettier) | `3.1.0` | `3.1.1` | | [stylelint-order](https://github.com/hudochenkov/stylelint-order) | `6.0.3` | `6.0.4` | Updates `vite` from 5.0.3 to 5.0.10 - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.0.10/packages/vite) Updates `eslint` from 8.54.0 to 8.56.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.54.0...v8.56.0) Updates `lint-staged` from 15.1.0 to 15.2.0 - [Release notes](https://github.com/okonet/lint-staged/releases) - [Changelog](https://github.com/lint-staged/lint-staged/blob/master/CHANGELOG.md) - [Commits](lint-staged/lint-staged@v15.1.0...v15.2.0) Updates `prettier` from 3.1.0 to 3.1.1 - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@3.1.0...3.1.1) Updates `stylelint-order` from 6.0.3 to 6.0.4 - [Release notes](https://github.com/hudochenkov/stylelint-order/releases) - [Changelog](https://github.com/hudochenkov/stylelint-order/blob/master/CHANGELOG.md) - [Commits](hudochenkov/stylelint-order@6.0.3...6.0.4) --- updated-dependencies: - dependency-name: vite dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-minor-updates - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor dependency-group: all-minor-updates - dependency-name: lint-staged dependency-type: direct:development update-type: version-update:semver-minor dependency-group: all-minor-updates - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch dependency-group: all-minor-updates - dependency-name: stylelint-order dependency-type: direct:development update-type: version-update:semver-patch dependency-group: all-minor-updates ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andre Almeida <[email protected]>

Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) from 0.34.6 to 1.0.4. - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Commits](https://github.com/vitest-dev/vitest/commits/v1.0.4/packages/vitest) --- updated-dependencies: - dependency-name: vitest dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andre Almeida <[email protected]> Co-authored-by: Alexandre Gomes <[email protected]>

…hatt#42) Bumps the all-minor-updates group with 4 updates: [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier), [sass](https://github.com/sass/dart-sass), [stylelint-order](https://github.com/hudochenkov/stylelint-order) and [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest). Updates `eslint-plugin-prettier` from 5.0.1 to 5.1.2 - [Release notes](https://github.com/prettier/eslint-plugin-prettier/releases) - [Changelog](https://github.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md) - [Commits](prettier/eslint-plugin-prettier@v5.0.1...v5.1.2) Updates `sass` from 1.69.5 to 1.69.6 - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](sass/dart-sass@1.69.5...1.69.6) Updates `stylelint-order` from 6.0.3 to 6.0.4 - [Release notes](https://github.com/hudochenkov/stylelint-order/releases) - [Changelog](https://github.com/hudochenkov/stylelint-order/blob/master/CHANGELOG.md) - [Commits](hudochenkov/stylelint-order@6.0.3...6.0.4) Updates `vitest` from 1.1.0 to 1.1.1 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Commits](https://github.com/vitest-dev/vitest/commits/v1.1.1/packages/vitest) --- updated-dependencies: - dependency-name: eslint-plugin-prettier dependency-type: direct:development update-type: version-update:semver-minor dependency-group: all-minor-updates - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-patch dependency-group: all-minor-updates - dependency-name: stylelint-order dependency-type: direct:development update-type: version-update:semver-patch dependency-group: all-minor-updates - dependency-name: vitest dependency-type: direct:development update-type: version-update:semver-patch dependency-group: all-minor-updates ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: input text component feat devhatt#21 * refactor: change px to rem in input text, edd the option to set de asset as prefix or suffix fix devhatt#21 * style: changed px to rem in background-position, removed fix devhatt#21 --------- Co-authored-by: Andre Almeida <[email protected]> Co-authored-by: Alexandre Gomes <[email protected]>

devhatt#48) * chore: Add new scripts and integrate prettier with stylelint * chore: padronized color format to rgba

) Bumps the all-minor-updates group with 4 updates: [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite), [jsdom](https://github.com/jsdom/jsdom), [sass](https://github.com/sass/dart-sass) and [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest). Updates `vite` from 5.0.10 to 5.0.11 - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.0.11/packages/vite) Updates `jsdom` from 23.0.1 to 23.2.0 - [Release notes](https://github.com/jsdom/jsdom/releases) - [Changelog](https://github.com/jsdom/jsdom/blob/main/Changelog.md) - [Commits](jsdom/jsdom@23.0.1...23.2.0) Updates `sass` from 1.69.6 to 1.69.7 - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](sass/dart-sass@1.69.6...1.69.7) Updates `vitest` from 1.1.1 to 1.1.3 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Commits](https://github.com/vitest-dev/vitest/commits/v1.1.3/packages/vitest) --- updated-dependencies: - dependency-name: vite dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-minor-updates - dependency-name: jsdom dependency-type: direct:development update-type: version-update:semver-minor dependency-group: all-minor-updates - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-patch dependency-group: all-minor-updates - dependency-name: vitest dependency-type: direct:development update-type: version-update:semver-patch dependency-group: all-minor-updates ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Andre Almeida <[email protected]>

…into main

…to main

Alecell

Vi que tem alteração em vários arquivos de config como o dependabot e os workflows. Acredito que foi uma alteração acidental, mas precisamos resolver isso, não pode haver alteração lá a menos que seja necessário

Alecell · 2024-01-31T20:56:46Z

src/components/more-info/index.js

+  inputText.mount(inputContainer);
+
+  if (!mockVaccines) {
+    // eslint-disable-next-line prettier/prettier


Verificar se ainda precisa desse comentario atualizando a branch

Alecell · 2024-01-31T20:57:01Z

src/components/more-info/index.js

+    // eslint-disable-next-line prettier/prettier
+    this.selected.get('render-vaccines').innerText = 'Nenhuma vacina cadastrada.';
+  } else {
+    // eslint-disable-next-line no-inner-declarations


Verificar se ainda rpecisa desse comentário com a atualização da branch

Alecell · 2024-01-31T20:58:04Z

src/components/more-info/index.js

+    <div class="vaccines-group">
+    <p class="vaccines-group__title">${vaccine}</p>
+    <div class="vaccines-group__date-group">
+    <img src="../components/more-info/assets/calendar.svg" alt="calendar" class="vaccines-group__date-group__icon">


Importar imagem da pasta local do seu componente, não da pasta assets

Alecell · 2024-01-31T20:58:37Z

src/components/more-info/index.js

+    const vaccinesContainer = this.selected.get('render-vaccines');
+    const dataVaccines = () => {
+      //preciso de ajuda para não precisar desabilitar a regra
+      // eslint-disable-next-line no-restricted-syntax


Atualizando a branch provavelmente vai resolver

Alecell · 2024-01-31T20:58:41Z

src/components/more-info/index.js

+      // eslint-disable-next-line no-restricted-syntax
+      for (const item of mockVaccines) {
+        //preciso de ajuda para não precisar desabilitar a regra
+        // eslint-disable-next-line prettier/prettier


Atualizando a branch provavelmente vai resolver

Alecell · 2024-01-31T21:04:07Z

src/components/more-info/index.scss

+.button_add {
+  display: flex;
+  align-items: center;
+  gap: 5px;


gap tambem deve ser feito em rem

Alecell · 2024-01-31T21:05:17Z

src/components/more-info/index.scss

+// apenas marcação exixte uma task para o checkbox que não é minha
+// Esconder o input radio
+input[type='radio'] {
+  display: none;
+}
+
+// Estilizar a aparência do label para se parecer com um checkbox
+input[type='radio'] + label .checkmark {
+  display: inline-block;
+  width: 1.3rem;
+  height: 1.3rem;
+  border: 2px solid #999;
+  border-radius: 3px;
+  cursor: pointer;
+}
+
+// Estilizar quando o input radio está selecionado
+input[type='radio']:checked + label .checkmark {
+  background-color: #5649e4;
+  border-color: #5649e4;
+  color: #fff;
+}


Pode apagar, mesmo que a task não esteja concluida vc não pode sujar seu componente com coisas que não são dele, só deixa essa observação no PR e gg

Alecell · 2024-01-31T21:06:23Z

src/home/index.scss

+body {
+  background-color: #003459;
+}
+.home-main-container {
+  display: flex;
+  justify-content: center;
+  gap: 1rem;
+  margin: 40px auto;
+


Não sei se isso está correto, talvez precisamos falar osbre

Alecell · 2024-01-31T21:06:29Z

src/home/index.scss

@@ -61,3 +71,4 @@
    }
  }
 }
+}


Alecell · 2024-01-31T21:08:13Z

src/home/main.js

Os comentários precisam ser descomentados pra que o componente e o use fique de exemplo pras outras pessoas no futuro. Vamos apagar quando houver mais componentes de exemplo, mas no momento isso precisa ser descomentado e mantido

Alecell · 2024-02-21T03:11:05Z

PR fechado decorrente de inatividade

hxsggsz added 3 commits December 1, 2023 16:35

ci: add template issues, templates pr and ci for auto assign tasks

6a376f9

refactor: add eof and fix project name

2189b50

refactor: remove create branch assign workflows

5723c64

aalmeida00 requested changes Jan 6, 2024

View reviewed changes

Alecell requested changes Jan 8, 2024

View reviewed changes

feat: update more info card

b640347

geisabitt force-pushed the issue-30 branch from ec94f23 to b640347 Compare January 12, 2024 00:48

aalmeida00 requested changes Jan 12, 2024

View reviewed changes

feat: add cards questions and list dinamic vaccine

3674aa8

geisabitt commented Jan 12, 2024

View reviewed changes

src/components/card-pet/index.js Outdated Show resolved Hide resolved

geisabitt marked this pull request as ready for review January 12, 2024 14:27

diogocaronte and others added 15 commits January 13, 2024 11:00

add prettier ignore

0fec67b

run prettier

3747d51

make counter works

eba66d6

chore: add commit lint, commitizien, husky, vitest and make build work

ef5c007

chore: some more changes

2e44d71

initial project architecture (devhatt#10)

75643ef

* add initial architecture example * fix node_modules in src * new structure example * refactor components * refactor: remove unused dependency * style: run prettier to fix EOF * add more tests

move utils to a new package

6414833

docs: created readme.md file (devhatt#12)

5b00c96

* docs: created readme.md file fix devhatt#5 * style: created readme.md file fix devhatt#5 * docs: created readme.md file with first steps fix devhatt#5

chore: add lint and pet-dex-utilities package

3461194

BREAKING CHANGE: Reinstall all dependencies

build: remove login page from build pages on vite config

342cb86

chore: update pnpm-lock with its new dependencies

e014c4f

PiluVitu and others added 5 commits January 13, 2024 11:00

Adicionado novos scripts no package e integrado stylelint com prettier (

e86e08a

devhatt#48) * chore: Add new scripts and integrate prettier with stylelint * chore: padronized color format to rgba

Merge branch 'main' of https://github.com/geisabitt/pet-dex-frontend …

5aeaaa4

…into main

Merge branch 'main' of https://github.com/devhatt/pet-dex-frontend in…

b6a088a

…to main

ci: add template issues, templates pr and ci for auto assign tasks

38d4ed0

PiluVitu assigned geisabitt Jan 29, 2024

merge main com a issue-30

1e3be19

Alecell requested changes Jan 31, 2024

View reviewed changes

Alecell unassigned geisabitt Feb 8, 2024

Alecell closed this Feb 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(more-info): adding question card and optional observation input #43

feat(more-info): adding question card and optional observation input #43

geisabitt commented Jan 5, 2024

aalmeida00 left a comment

Alecell commented Jan 8, 2024

aalmeida00 commented Jan 9, 2024

geisabitt left a comment

geisabitt commented Jan 12, 2024

geisabitt commented Jan 12, 2024

Alecell left a comment

Alecell Jan 31, 2024

Alecell Jan 31, 2024

Alecell Jan 31, 2024

Alecell Jan 31, 2024

Alecell Jan 31, 2024

Alecell Jan 31, 2024

Alecell Jan 31, 2024

Alecell Jan 31, 2024

Alecell Jan 31, 2024

Alecell Jan 31, 2024

Alecell commented Feb 21, 2024

@@ @@ -61,3 +71,4 @@ @@
                   }
                 }
               }
+              }

feat(more-info): adding question card and optional observation input #43

feat(more-info): adding question card and optional observation input #43

Conversation

geisabitt commented Jan 5, 2024

aalmeida00 left a comment

Choose a reason for hiding this comment

Alecell commented Jan 8, 2024

aalmeida00 commented Jan 9, 2024

geisabitt left a comment

Choose a reason for hiding this comment

geisabitt commented Jan 12, 2024

geisabitt commented Jan 12, 2024

Alecell left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Alecell commented Feb 21, 2024