Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Progress bar Issue#22 #53

Merged
merged 10 commits into from
Feb 27, 2024
Merged

Feat: Progress bar Issue#22 #53

merged 10 commits into from
Feb 27, 2024

Conversation

JonySamarelli
Copy link
Contributor

@JonySamarelli JonySamarelli commented Jan 11, 2024

Closes #22

Feature

Criado componente de barra de progresso, com quantidade de etapas personalizáveis

Visual evidences 🖼️

20240111_125248

Checklist
  • Issue linked
  • Build working correctly
  • Tests created
Visual evidences 🖼️ ![image](https://github.com/devhatt/pet-dex-frontend/assets/74078324/ae19556c-c66a-49eb-a852-c4b400f350a6)

Copy link
Member

@aalmeida00 aalmeida00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alguns pontinhos aqui.

src/components/ProgressBar/index.scss Outdated Show resolved Hide resolved
src/components/ProgressBar/index.scss Outdated Show resolved Hide resolved
src/components/ProgressBar/index.spec.js Outdated Show resolved Hide resolved
src/styles/base.scss Outdated Show resolved Hide resolved
src/components/ProgressBar/index.js Outdated Show resolved Hide resolved
src/components/ProgressBar/index.js Outdated Show resolved Hide resolved
src/components/ProgressBar/index.js Outdated Show resolved Hide resolved
src/components/ProgressBar/index.js Outdated Show resolved Hide resolved
src/components/ProgressBar/index.scss Outdated Show resolved Hide resolved
src/components/ProgressBar/index.scss Outdated Show resolved Hide resolved
src/components/ProgressBar/index.scss Outdated Show resolved Hide resolved
src/components/ProgressBar/index.spec.js Outdated Show resolved Hide resolved
@Alecell
Copy link
Contributor

Alecell commented Jan 18, 2024

Man vc resolveu os problema citados? To perguntando pq os comentarios não foram marcados como resolved, sempre que resolver um problema marca como resolved

@JonySamarelli
Copy link
Contributor Author

Man vc resolveu os problema citados? To perguntando pq os comentarios não foram marcados como resolved, sempre que resolver um problema marca como resolved

Opa, resolvi sim, foi mal na minha última empresa os revisores que fechavam os pontos após as correções

@Alecell
Copy link
Contributor

Alecell commented Jan 18, 2024

Eita, que diferente!

Tranquilo man, só marca os lances pq aqui é osso eu revisar assim tao no detalhe! x.x

@PiluVitu PiluVitu assigned PiluVitu and JonySamarelli and unassigned PiluVitu Jan 29, 2024
@JonySamarelli
Copy link
Contributor Author

@PiluVitu feito

src/styles/base.scss Outdated Show resolved Hide resolved
src/styles/colors.scss Outdated Show resolved Hide resolved
src/styles/colors.scss Outdated Show resolved Hide resolved
src/styles/base.scss Show resolved Hide resolved
src/components/ProgressBar/index.spec.js Show resolved Hide resolved
src/components/ProgressBar/index.scss Outdated Show resolved Hide resolved
src/components/ProgressBar/index.scss Outdated Show resolved Hide resolved
@Alecell Alecell merged commit 3d720ca into devhatt:main Feb 27, 2024
JonasGz pushed a commit to JonasGz/pet-dex-frontend-p4n4 that referenced this pull request Feb 29, 2024
* Feat: Add ProgressBar component with styles

* Fix: Refactor ProgressBar initialization logic

* test: Create ProgressBar unit tests

* Refactor: ProgressBar component

* Refactor: eof

* refactor: ProgressBar test typos fix

* Refactor: Update ProgressBar styles to use colors from colors.scss

* Update src/styles/base.scss

Co-authored-by: Paulo Victor  <[email protected]>

* refactor: Refactor: Update colors to rgb and remove unnecessary variable

re devhatt#22

* style: style: Ajustes do lint

---------

Co-authored-by: Paulo Victor <[email protected]>
JonasGz pushed a commit to JonasGz/pet-dex-frontend-p4n4 that referenced this pull request Mar 4, 2024
* Feat: Add ProgressBar component with styles

* Fix: Refactor ProgressBar initialization logic

* test: Create ProgressBar unit tests

devhatt#22

* Refactor: ProgressBar component

* Refactor: eof

* refactor: ProgressBar test typos fix

* Refactor: Update ProgressBar styles to use colors from colors.scss

* Update src/styles/base.scss

Co-authored-by: Paulo Victor  <[email protected]>

* refactor: Refactor: Update colors to rgb and remove unnecessary variable

re devhatt#22

* style: style: Ajustes do lint

---------

Co-authored-by: Paulo Victor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Criação de Componente de Barra de Progresso
5 participants